add connector.version as build property #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
odeke-em
reviewed
Nov 8, 2023
spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerUtils.java
Outdated
Show resolved
Hide resolved
spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerUtils.java
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
davidrabinowitz
requested changes
Nov 8, 2023
| Properties buildProperties = new Properties(); | ||
| buildProperties.load( | ||
| SpannerUtils.class.getResourceAsStream("/spark-spanner-connector.properties")); | ||
| System.out.println(buildProperties.getProperty("connector.version")); |
There was a problem hiding this comment.
Please don't use System.out.println(), replace it with logger
| System.out.println(buildProperties.getProperty("connector.version")); | ||
| return buildProperties; | ||
| } finally { | ||
| System.out.println("FAILED"); |
There was a problem hiding this comment.
Please don't use System.out.println(), replace it with logger
davidrabinowitz
requested changes
Nov 8, 2023
| @@ -0,0 +1,2 @@ | |||
| #connector.version=${project.version} | |||
| connector.version=3.1 | |||
There was a problem hiding this comment.
Any reason for that? the idea is to track the connector's version for the user agent
davidrabinowitz
requested changes
Nov 8, 2023
| SpannerUtils.class.getResourceAsStream("/spark-spanner-connector.properties")); | ||
| return buildProperties; | ||
| } finally { | ||
| return new Properties(); |
|
Let's revert the pr. Since it's out of date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.