Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation for modification/removal of sets #592

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

sjledoux
Copy link
Collaborator

The current RWS checks account for PRs that attempt to update or remove Related Website Sets from the canonical list, however this behavior isn't explicitly documented in the submission guidelines or quick start guide. This change adds that information to the public documentation so that submitters can better understand how to update or remove their sets from the canonical list.

Copy link
Collaborator

@cfredric cfredric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with formatting nits

Getting-Started.md Outdated Show resolved Hide resolved
RWS-Submission_Guidelines.md Outdated Show resolved Hide resolved
Copy link

Looks like you've passed all of the checks!

Copy link
Collaborator

@cfredric cfredric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge when ready!

@sjledoux sjledoux merged commit 7280d0f into main Nov 19, 2024
4 checks passed
@sjledoux sjledoux deleted the Add-Removal-Documentation branch November 19, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants