Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Added "attribution reporting: a primer" post #962

Merged
merged 7 commits into from
Aug 9, 2021
Merged

Added "attribution reporting: a primer" post #962

merged 7 commits into from
Aug 9, 2021

Conversation

maudnals
Copy link
Contributor

@maudnals maudnals commented Jul 6, 2021

@netlify
Copy link

netlify bot commented Jul 6, 2021 •
edited
Loading

✔️ Deploy Preview for developer-chrome-com ready!

🔨 Explore the source changes: 9d7f133

🔍 Inspect the deploy log: https://app.netlify.com/sites/developer-chrome-com/deploys/611148df3a18cf000897cf07

😎 Browse the preview: https://deploy-preview-962--developer-chrome-com.netlify.app

@google-cla google-cla bot added the cla: yes label Jul 6, 2021
@google-cla google-cla bot added the cla: yes label Jul 6, 2021
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/privacy-sandbox/attribution-reporting-primer/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/privacy-sandbox/status/index.md

  • Please put a blank line before and after each section heading. Some Markdown parsers don't detect the text as a section heading unless there is blank space before and after it. Affected lines: 33, 44, 52, 63, 87
  • Please change your usage of the following words:
    • Do not use master. Affected lines: 67, 69

1 similar comment
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/privacy-sandbox/attribution-reporting-primer/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/privacy-sandbox/status/index.md

  • Please put a blank line before and after each section heading. Some Markdown parsers don't detect the text as a section heading unless there is blank space before and after it. Affected lines: 33, 44, 52, 63, 87
  • Please change your usage of the following words:
    • Do not use master. Affected lines: 67, 69

@maudnals
Copy link
Contributor Author

maudnals commented Jul 9, 2021

Waiting on resolution on WICG/attribution-reporting-api#170 to adapt the use cases section

@maudnals maudnals requested a review from samdutton August 9, 2021 12:51
mihajlija
mihajlija reviewed Aug 9, 2021
View reviewed changes
site/en/docs/privacy-sandbox/attribution-reporting-primer/index.md Outdated
@@ -0,0 +1,596 @@
---
layout: 'layouts/doc-post.njk'
title: 'Attribution Reporting (Conversion Measurement): a primer'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'Attribution Reporting (Conversion Measurement): a primer'
title: 'Introduction to Attribution Reporting (Conversion Measurement)'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to use a more common word.

mihajlija
mihajlija reviewed Aug 9, 2021
View reviewed changes
site/en/docs/privacy-sandbox/attribution-reporting-primer/index.md Outdated

<figure>
{% Img src="image/O2RNUyVSLubjvENAT3e7JSdqSOx1/HAl0ppkoxoGCtttWDk2A.png", alt="ALT_TEXT_HERE", width="800", height="1140" %}
<figcaption>Aggregate reports are generated as follows: the browser matches detailed clicks or views ("attribution source events") with detailed conversion data ("attribution trigger data") defined by an adtech. Adtech-defined code runs in a worklet to define contributions that will be sent by the browser in order to be used to compute aggregate reports. Aggregation services are responsible for privately computing aggregate reports for adtech.</figcaption>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest pulling these descriptions out of the caption element, and into paragraph text. The longer captions (below) don't look good with centred formatting.

@maudnals maudnals merged commit bfd4d7a into main Aug 9, 2021
@maudnals maudnals deleted the maudn-attribution-reporting-primer branch August 9, 2021 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mihajlija mihajlija mihajlija approved these changes

@samdutton samdutton samdutton approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maudnals @chrome-devrel-review-bot @samdutton @mihajlija