Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup notifications #159

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Cleanup notifications #159

merged 4 commits into from
Dec 19, 2024

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Dec 19, 2024

Reduces some logic duplication and makes it easier to send notifications

Also adds a notification for when the layout is successfully exported

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.22%. Comparing base (4d0f72a) to head (613f215).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/pages/dashboard_page.dart 47.36% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   68.18%   68.22%   +0.03%     
==========================================
  Files          79       79              
  Lines        8245     8252       +7     
==========================================
+ Hits         5622     5630       +8     
+ Misses       2623     2622       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit 4b91f8f into main Dec 19, 2024
9 checks passed
@Gold872 Gold872 deleted the notifications-cleanup branch December 19, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant