Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Python Support for elasticlib #138

Closed
wants to merge 1 commit into from
Closed

Adds Python Support for elasticlib #138

wants to merge 1 commit into from

Conversation

Ryanforce08
Copy link

Used Black Formatting and WPI Format

@DanPeled
Copy link
Contributor

DanPeled commented Nov 22, 2024 •
edited
Loading

This is a duplicate PR (#136 already exists), and you also seem to have some methods missing

@Ryanforce08
Copy link
Author

Dang I did not see. yours is better anyways

@DanPeled
Copy link
Contributor

i would recommend closing the PR then

@Ryanforce08
Copy link
Author

Just realized mine has better docs is there away to add my docs to yours

@DanPeled
Copy link
Contributor

Just realized mine has better docs is there away to add my docs to yours

I am copying the docs from the Java & C++ versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryanforce08 @DanPeled