Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the conventions set in Rails since 2018, replacing the use of the term 'blacklist'. I've proposed using the word 'revoke' ('revoked_tokens', 'revocation') to replace it in the context of this gem, since it's applicable to the effects on the token.
@Gokul595 this should work from here for new adopters of the gem (such as myself), but obviously this will create conflicts for those already using it since they will already have a database table named
blacklisted_tokens
. Off the top of my head the Readme could be expanded to suggest:blacklisted_tokens
table.blacklisted_tokens
table to the new name.Or perhaps we could add a fallback in the code where if the
revoked_tokens
table doesn't exist, it would look for theblacklisted_tokens
table? This would make the upgrade transparent for existing users, and the Readme could note thisDo you have any thoughts on an approach for this (assuming you'd like to merge this in)?