Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Packaging #13

wants to merge 5 commits into from

Conversation

spameier
Copy link

I like to install tools using pipx therefore i created a package from the script. The script can now be installed using pipx install git+https://github.com/spameier/pywsus@packaging.

update_handler has to be defined as a global variable, otherwise bigger changes to the script are required.

@obilodeau
Copy link
Collaborator

This looks good to me. Can you update the README to provide the new installation instructions, please?

@spameier
Copy link
Author

spameier commented Nov 7, 2022

Sorry, I've only seen your comment just now. I updated the installation instructions and also the help text because that was a bit outdated.

@spameier
Copy link
Author

I avoided the global keyword by using functools.partial. If you don't like this addition, I can revert the commit of course.

@spameier
Copy link
Author

Hello may I ask for an update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants