-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Support XML DTD #10
base: master
Are you sure you want to change the base?
Conversation
8cd2a2d
to
2f4cdc6
Compare
9b36887
to
4beb1e8
Compare
It seems to support the latest Metaschema, re the linked issue in usnistgov/OSCAL#1665, support for XML DTDs is no longer required for the OSCAL Metaschema models, should we close this @isimluk? |
That's a great news @xee5ch. Thank You! |
This test needs to pass when gocomply/metaschema supports XML DTD.
Note DTD implementation in golang xml parser is not straight forward yet doable.
FYI: I just found that OSCAL is still depending on DTD in the oscal_control-common_metaschema.xml |
looks like they are exporting things as "_RESOLVED" to get around this, Using this zip https://github.com/usnistgov/OSCAL/releases/download/v1.1.2/oscal-1.1.2.zip and the "metaschema" folder i was able to get to here:
|
In order to support the latest usnistgov/metaschema, we need to support XML DTD.
usnistgov/metaschema started including XML DTD tags, we need to support these.