Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support XML DTD #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Support XML DTD #10

wants to merge 2 commits into from

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Nov 8, 2022

In order to support the latest usnistgov/metaschema, we need to support XML DTD.

usnistgov/metaschema started including XML DTD tags, we need to support these.

@xee5ch
Copy link

xee5ch commented Sep 20, 2023

It seems to support the latest Metaschema, re the linked issue in usnistgov/OSCAL#1665, support for XML DTDs is no longer required for the OSCAL Metaschema models, should we close this @isimluk?

@isimluk
Copy link
Member Author

isimluk commented Sep 20, 2023

That's a great news @xee5ch. Thank You!

@isimluk isimluk closed this Sep 20, 2023
isimluk added 2 commits March 11, 2024 17:43
This test needs to pass when gocomply/metaschema supports XML DTD.
Note DTD implementation in golang xml parser is not straight forward yet
doable.
@isimluk
Copy link
Member Author

isimluk commented Mar 12, 2024

FYI: I just found that OSCAL is still depending on DTD in the oscal_control-common_metaschema.xml

https://github.com/usnistgov/OSCAL/blob/4f02dac6f698efda387cc5f55bc99581eaf494b6/src/metaschema/oscal_control-common_metaschema.xml#L2-L8

@mdk-arc
Copy link

mdk-arc commented Apr 20, 2024

looks like they are exporting things as "_RESOLVED" to get around this, Using this zip https://github.com/usnistgov/OSCAL/releases/download/v1.1.2/oscal-1.1.2.zip and the "metaschema" folder i was able to get to here:

 Processing  oscal_assessment-common_metaschema_RESOLVED.xml
  Processing imported href: oscal_control-common_metaschema_RESOLVED.xml
  Processing imported href: oscal_metadata_metaschema_RESOLVED.xml
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x523e41]

goroutine 1 [running]:
github.com/gocomply/metaschema/metaschema/parser.(*Metaschema).linkDefinitions(0xc0002d1600)
	/home/arclight/prj/metaschema/metaschema/parser/metaschema_compile.go:75 +0xc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants