fix user tests

Go-Marketplace · Dec 5, 2023 · f2f168c · f2f168c
1 parent b98994b
commit f2f168c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/user/internal/api/grpc/controller/user.go b/user/internal/api/grpc/controller/user.go
@@ -192,8 +192,8 @@ func ChangeUserRole(ctx context.Context, userUsecase usecase.IUserUsecase, req *
 		return nil, status.Errorf(codes.InvalidArgument, "Invalid user id: %s", err)
 	}
 
-	if req.Role == pbUser.UserRole_SUPERADMIN || req.Role == pbUser.UserRole_GUEST {
-		return nil, status.Errorf(codes.InvalidArgument, "Invalid role request: %s", err)
+	if req.Role >= pbUser.UserRole_SUPERADMIN || req.Role <= pbUser.UserRole_GUEST {
+		return nil, status.Errorf(codes.InvalidArgument, "Invalid role request")
 	}
 
 	user, err := userUsecase.ChangeUserRole(ctx, userID, model.UserRoles(req.Role))

diff --git a/user/internal/api/grpc/controller/user_test.go b/user/internal/api/grpc/controller/user_test.go
@@ -92,7 +92,7 @@ func TestChangeUserRole(t *testing.T) {
 			},
 			mock:         func(usecase *mocks.MockIUserUsecase) {},
 			expectedUser: nil,
-			expectedErr:  status.Errorf(codes.InvalidArgument, "Invalid request: %s", fmt.Errorf("Key: 'User.Role' Error:Field validation for 'Role' failed on the 'oneof' tag")),
+			expectedErr:  status.Errorf(codes.InvalidArgument, "Invalid role request"),
 		},
 		{
 			name: "Got error when change user role in usecase",