Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update jose and openid-client lib #397

Merged
merged 9 commits into from
Jan 18, 2022
Merged

build: update jose and openid-client lib #397

merged 9 commits into from
Jan 18, 2022

Conversation

kdhttps
Copy link
Contributor

@kdhttps kdhttps commented Dec 28, 2021 •
edited by christian-hawk
Loading

close #309

Note: node engine updated. [email protected] need node >= 16.13.0.

Edit

Node update not needed, new issue opened #407

@kdhttps kdhttps self-assigned this Dec 28, 2021
@codecov
Copy link

codecov bot commented Dec 28, 2021 •
edited
Loading

Codecov Report

Merging #397 (de1a927) into master (2d735d3) will increase coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head de1a927 differs from pull request most recent head 6f5e1ce. Consider uploading reports for the commit 6f5e1ce to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   78.37%   78.58%   +0.21%     
==========================================
  Files          36       36              
  Lines         777      780       +3     
==========================================
+ Hits          609      613       +4     
+ Misses        168      167       -1
Impacted Files Coverage Δ
server/utils/openid-client-helper.js 100.00% <100.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d735d3...6f5e1ce. Read the comment docs.

@christian-hawk
Copy link
Contributor

run tests

6 similar comments
@christian-hawk
Copy link
Contributor

run tests

@christian-hawk
Copy link
Contributor

run tests

@christian-hawk
Copy link
Contributor

run tests

@christian-hawk
Copy link
Contributor

run tests

@christian-hawk
Copy link
Contributor

run tests

@christian-hawk
Copy link
Contributor

run tests

christian-hawk
christian-hawk suggested changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@christian-hawk christian-hawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments regarding integration and unit tests, thanks for the PR.

test/openid-client-helper.spec.js Outdated Show resolved Hide resolved
server/utils/openid-client-helper.js Outdated Show resolved Hide resolved
christian-hawk
christian-hawk suggested changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@christian-hawk christian-hawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added node version comment

package.json Show resolved Hide resolved
@christian-hawk christian-hawk changed the title update jose and openid-client lib latest build: update jose and openid-client lib Jan 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@christian-hawk christian-hawk merged commit a857f4a into master Jan 18, 2022
@christian-hawk christian-hawk deleted the 309_jose_update branch January 18, 2022 20:24
@christian-hawk christian-hawk mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-hawk christian-hawk christian-hawk approved these changes

Assignees

@kdhttps kdhttps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update jose to 3.x (breaking changes) needs
2 participants
@kdhttps @christian-hawk