Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗺 Rudimentary routing logic #9

Merged
merged 1 commit into from
Nov 25, 2020
Merged

🗺 Rudimentary routing logic #9

merged 1 commit into from
Nov 25, 2020

Conversation

haydenmc
Copy link
Member

This change adds Orchestrator logic directing Ingest nodes to relay streams to Edge nodes that are subscribed, plus a simple unit test to validate this logic.

Relay nodes are not yet considered when constructing routes.

Copy link
Contributor

@danstiner danstiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall!

One comment about ingest->SetOnStreamRelay() that might be an issue, two other comments about minor C++ style stuff

src/SubscriptionStore.h Show resolved Hide resolved
src/SubscriptionStore.h Show resolved Hide resolved
test/unit/OrchestratorUnitTests.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants