chore: Enable pipeline experiments in dashboard configuration files

Gkrumbach07 · Jun 7, 2024 · fd3e7ab · fd3e7ab
1 parent 23ae524
commit fd3e7ab
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 12 deletions.
diff --git a/backend/src/utils/constants.ts b/backend/src/utils/constants.ts
@@ -61,7 +61,7 @@ export const blankDashboardCR: DashboardConfig = {
       disableKServeMetrics: true,
       disableModelMesh: false,
       disableAcceleratorProfiles: false,
-      disablePipelineExperiments: true,
+      disablePipelineExperiments: false,
       disableDistributedWorkloads: false,
       disableModelRegistry: true,
     },

diff --git a/docs/dashboard-config.md b/docs/dashboard-config.md
@@ -156,7 +156,7 @@ spec:
     disableKServeMetrics: true
     disableBiasMetrics: false
     disablePerformanceMetrics: false
-    disablePipelineExperiments: true
+    disablePipelineExperiments: false
   notebookController:
     enabled: true
     gpuSetting: autodetect

diff --git a/frontend/src/__mocks__/mockDashboardConfig.ts b/frontend/src/__mocks__/mockDashboardConfig.ts
@@ -48,7 +48,7 @@ export const mockDashboardConfig = ({
   disableAcceleratorProfiles = false,
   disablePerformanceMetrics = false,
   disableBiasMetrics = false,
-  disablePipelineExperiments = true,
+  disablePipelineExperiments = false,
   disableDistributedWorkloads = false,
   disableModelRegistry = true,
   disableNotebookController = false,

diff --git a/frontend/src/concepts/pipelines/content/tables/pipelineVersion/PipelineVersionTableRow.tsx b/frontend/src/concepts/pipelines/content/tables/pipelineVersion/PipelineVersionTableRow.tsx
@@ -8,6 +8,7 @@ import PipelinesTableRowTime from '~/concepts/pipelines/content/tables/Pipelines
 import { PipelineRunType } from '~/pages/pipelines/global/runs/types';
 import { PipelineRunSearchParam } from '~/concepts/pipelines/content/types';
 import { routePipelineRunCreateNamespacePipelinesPage, routePipelineRunsNamespace } from '~/routes';
+import { SupportedArea, useIsAreaAvailable } from '~/concepts/areas';
 
 type PipelineVersionTableRowProps = {
   isChecked: boolean;
@@ -35,6 +36,7 @@ const PipelineVersionTableRow: React.FC<PipelineVersionTableRowProps> = ({
   const navigate = useNavigate();
   const { namespace } = usePipelinesAPI();
   const createdDate = new Date(version.created_at);
+  const isExperimentsAvailable = useIsAreaAvailable(SupportedArea.PIPELINE_EXPERIMENTS).status;
 
   return (
     <Tr data-testid={`pipeline-version-row ${version.pipeline_version_id}`}>
@@ -97,7 +99,9 @@ const PipelineVersionTableRow: React.FC<PipelineVersionTableRowProps> = ({
               onClick: () => {
                 navigate(
                   {
-                    pathname: routePipelineRunsNamespace(namespace),
+                    pathname: isExperimentsAvailable
+                      ? route
+                      : routePipelineRunsNamespace(namespace),
                     search: `?${PipelineRunSearchParam.RunType}=${PipelineRunType.ACTIVE}`,
                   },
                   {

diff --git a/frontend/src/pages/pipelines/GlobalPipelinesRoutes.tsx b/frontend/src/pages/pipelines/GlobalPipelinesRoutes.tsx
@@ -22,6 +22,7 @@ import {
   routePipelinesNamespace,
 } from '~/routes';
 import GlobalPipelines from './global/pipelines/GlobalPipelines';
+import GlobalPipelineRuns from './global/runs/GlobalPipelineRuns';
 
 const GlobalPipelinesRoutes: React.FC = () => (
   <ProjectsRoutes>

diff --git a/frontend/src/utilities/NavData.tsx b/frontend/src/utilities/NavData.tsx
@@ -68,14 +68,18 @@ const useDSPipelinesNav = (): NavDataItem[] => {
   }
 
   return [
-    {
-      id: 'pipelines',
-      group: { id: 'pipelines', title: 'Data Science Pipelines' },
-      children: [
-        { id: 'global-pipelines', label: 'Pipelines', href: routePipelines() },
-        { id: 'global-pipeline-runs', label: 'Runs', href: routePipelineRuns() },
-      ],
-    },
+    ...(isExperimentsAvailable
+      ? [{ id: 'pipelines', label: 'Data Science Pipelines', href: routePipelines() }]
+      : [
+          {
+            id: 'pipelines',
+            group: { id: 'pipelines', title: 'Data Science Pipelines' },
+            children: [
+              { id: 'global-pipelines', label: 'Pipelines', href: routePipelines() },
+              { id: 'global-pipeline-runs', label: 'Runs', href: routePipelineRuns() },
+            ],
+          },
+        ]),
     ...(isExperimentsAvailable
       ? [
           {