Use Blockscout as the default block explorer #4206
Conversation
|
@maxaleks is attempting to deploy a commit to the Giveth Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent updates primarily focus on enhancing the user interface and configuration settings. Key changes include updating button labels and hyperlinks to reflect the switch from Etherscan to Blockscout, renaming configuration variables with a "Default" suffix, and introducing a utility function to update block explorer URLs dynamically based on the chain ID. These modifications aim to improve clarity and functionality across the application. Changes
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- src/components/views/nft/mint/NFTMintIndex.tsx (1 hunks)
- src/config/development.tsx (4 hunks)
- src/config/production.tsx (3 hunks)
- src/config/utils.tsx (1 hunks)
- src/content/FAQ.tsx (1 hunks)
Additional Context Used
Biome (10)
src/components/views/nft/mint/NFTMintIndex.tsx (1)
107-110: Template literals are preferred over string concatenation.
src/config/development.tsx (2)
10-11: All these imports are only used as types.
11-19: Some named imports are only used as types.
src/config/production.tsx (5)
171-171: Do not use template literals if interpolation and special-character handling are not needed.
211-211: Do not use template literals if interpolation and special-character handling are not needed.
233-233: Do not use template literals if interpolation and special-character handling are not needed.
11-12: All these imports are only used as types.
12-20: Some named imports are only used as types.
src/config/utils.tsx (1)
13-14: All these imports are only used as types.
src/content/FAQ.tsx (1)
6-6: Unexpected any. Specify a different type.
Additional comments not posted (6)
src/config/utils.tsx (1)
31-43: The implementation ofupdateBlockExplorersfunction looks good and adheres to modern JavaScript practices.src/config/development.tsx (1)
88-94: The updates to the variable names and the addition of theupdateBlockExplorersfunction call are correctly implemented and align with the PR's objectives.src/config/production.tsx (3)
2-8: Updated variable names to include 'Default' suffix to reflect the new default settings.
30-30: Import statement forupdateBlockExplorersfunction added. Ensure this function is implemented correctly inutils.tsx.
58-64: Calls toupdateBlockExplorersfor each network to update block explorer URLs. Verify that these function calls are correctly updating the URLs as intended.src/content/FAQ.tsx (1)
276-277: Updated hyperlink to point to Blockscout, aligning with the PR's objective to use Blockscout as the default block explorer.
| @@ -139,7 +139,7 @@ export const NFTMintIndex = () => { | |||
| </DescCenter> | |||
| <ButtonLink | |||
| linkType='texty' | |||
| label='View transaction on etherscan' | |||
| label='View transaction on Blockscout' | |||
There was a problem hiding this comment.
The button label change aligns with the PR's objective. Consider using template literals for constructing URLs to improve readability.
- href={`${config.MAINNET_CONFIG.blockExplorers?.default.url}/tx/${txHash}`}
+ href={\`${config.MAINNET_CONFIG.blockExplorers?.default.url}/tx/${txHash}\`}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| label='View transaction on Blockscout' | |
| label='View transaction on Blockscout' | |
| href={`${config.MAINNET_CONFIG.blockExplorers?.default.url}/tx/${txHash}`} |
|
could you please confirm this PR is for which product requirement @maxaleks |
|
Hey @jainkrati, I talked with Griff about switching from Etherscan to Blockscout to support open-source public goods. We discussed that Giveth doesn't have enough resources to make the changes, so we agreed to take on this initiative ourselves hence the PR. |
|
@jainkrati The concept is that etherscan is closed source and centralized, so supporting open source alternatives is good for the ecosystem. I would love to hear @divine-comedian's opinion on if changing the default block explorer to blockscout is going to be an issue or not. |
|
Yeah I understand but... etherscan is a better blockchain explorer, I've had frequent issues with blockscout not indexing transactions or loading slow etc.. - I think this would be extra amount of work to imho make a not important change for Giveth. |
Can you provide specifics on our instances you had issues with? What makes Etherscan superior? The last 3 months Blockscout has had a higher up time the Etherscan making it more reliable. Apart from supporting other open source projects Blockscout has an easier and more updated UI for users performing TXs which utilizes AI to decode transactions. Also you mention its more work, does the PR not suffice? do we need to make changes? @divine-comedian |
|
We use etherscan and it's chain specific deployments all over the app so I don't have a full view of changing this one file will create more issues for us. I had issues with blockscout not loading gnosis chain for a while, maybe early last year. We also don't have any of our contracts verified on blockscout and I have had a hell of a time when I did once try to verify our contracts with it. Introducing this change could have unexpected UI bugs in our dapp. We have a lot of priorities on our plate right now with Giveth and switching our block explorer is just not very important right now. Our current block explorer solution is free, and it works as expected so I don't think we will be making any changes to this for now. |
|
Hey @divine-comedian, following up on our conversation from ETHGlobal! Since you had a chance to try out Blockscout there, maybe we could revisit this PR? 👀 |
|
hey @divine-comedian Max resolved the issues can you please take a look when you have a chance 🙏 |
Summary by CodeRabbit
New Features
Improvements
Documentation