Update LibGit2Sharp to 0.25.0-preview-0033 #1416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlowe
force-pushed
the
feat/UpgradeLibGit2Sharp
branch
from
eb1bab8 to
e4e17ef
Compare
|
Rebased on master, there were a lot of conflicts with the recent dotnet core merge. |
|
Sorry guys, it looks like multiple people have tried to do the same thing and there are overlapping pr's. Im closing this one in favour of #1422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1248, this Upgrades
LibGit2Sharpto0.25.0-preview-0033. Getting tests to pass required upgradingGitTools.TestingandGitTools.Coreto the latest version.GitTools.Testing's minimum target is4.5.2, so the testing projects had to be upgraded.Starting with
0.25.0-preview-0073,LibGit2Sharpisnetstandard2.0only. I ran into target file issues with the targets that add references to the native binaries. I have to look into this more but I believe the simplest solution is to go straight tonetstandard2.0here (#1175 ?). If you're uncomfortable running on a pre-release, I can re-do this to target 0.24.1 as it still fixes #1415 for me. Let me know what you think.Fixes #1415