move common project properties to Directory.Build.props #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
requested changes
Jan 10, 2025
arturcic
force-pushed
the
feature/common-props
branch
from
a4eba97 to
943405a
Compare
|
@gep13 updated, please have a new look |
|
would be nice if you can give it locally a try as well. |
|
@arturcic the changes themselves here look good, but something is going on with the CI build, that I will need to take a look at. Leave it with me, and I will get back to you if/when I find something. |
Sure, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the maintenance of the common properties. When we upgrade to .net80 and .net90, that will be much simpler