Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 24 and 32 bit .wav's #13

Merged
merged 1 commit into from
May 19, 2022
Merged

Add support for 24 and 32 bit .wav's #13

merged 1 commit into from
May 19, 2022

Conversation

L4Vo5
Copy link
Contributor

@L4Vo5 L4Vo5 commented Apr 16, 2022

Apparently those .wav's are always format_code 3?

The conversion is SLOW on long files (like songs).
It requires going through every byte to do the conversion.
So if performance is important, GDScript is just not fast enough for this.

Should fix #7 and #10

Apparently those .wav's are always format_code 3?

The conversion is SLOW on long files (like songs).
It requires going through every byte to do the conversion.
So if performance is important, GDScript is just not fast enough for this.
@IAMACAR10
Copy link

i am pretty sure #3 also had a similar issue, this might also fix that

@L4Vo5
Copy link
Contributor Author

L4Vo5 commented May 18, 2022

i am pretty sure #3 also had a similar issue, this might also fix that

It didn't when I checked sadly. That .wav has a different issue.

@Gianclgar
Copy link
Owner

Apparently those .wav's are always format_code 3?

The conversion is SLOW on long files (like songs). It requires going through every byte to do the conversion. So if performance is important, GDScript is just not fast enough for this.

Should fix #7 and #10

Yup, as I say in the readme file of this script, this script will only be necessary until its funcion gets implemented at the core engine, or via GDNative (I think it should be at Core since everything we do here the engine already does it when importing resources but it doesn't at runtime)

Thanks a lot for the contributions and comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The parsed format code is 3, so it doesn't work
4 participants