Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed solution for Issue #22 App upgrade/update command #52

Closed
wants to merge 4 commits into from
Closed

Proposed solution for Issue #22 App upgrade/update command #52

wants to merge 4 commits into from

Conversation

RealLukeMartin
Copy link
Member

Update global Valkyrie and it's submodules with a drush valkyrie-upgrade or drush vug

@@ -121,7 +121,11 @@ function valkyrie_drush_command() {
'aliases' => array('vup'),
'bootstrap' => DRUSH_BOOTSTRAP_DRUSH, // No bootstrap at all.
);

$items['valkyrie-upgrade'] = array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we're doing lots of other updating and upgrading, I'd suggest 'valkyrie-self-upgrade' or '...-self-update'.

@RealLukeMartin
Copy link
Member Author

Good to know there is a way to show output with drush_shell_exec() now, I went with drush_shell_proc_open() primarily because I saw the output out of the box, but going to switch that back now that I know about drush_get_option().

I first tried out the drush_shell_cd_and_exec() but was having issues with git recognizing the working tree, although with the changes you suggested about not going the git route and more the valkyrie project I think that won't be a problem.

I'll make those changes, remove the submodule mentions and send another PR when I have all that set up.

@ergonlogic
Copy link
Member

Actually, what I mean was not to show the output of git pull unless the user specified --debug. to get output from drush_shell_exec(), use drush_shell_exec_output(), iirc.

@RealLukeMartin
Copy link
Member Author

Cool I go with it as an option. For testing, the output helped a lot, but not really that necessary for the average user unless they really want to see it .

@ergonlogic ergonlogic added this to the 0.6.0 milestone Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants