Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rn-video): upgrade to expo ver 52 #1630

Merged
merged 8 commits into from
Jan 3, 2025
Merged

chore(rn-video): upgrade to expo ver 52 #1630

merged 8 commits into from
Jan 3, 2025

Conversation

kristian-mkd
Copy link
Contributor

@kristian-mkd kristian-mkd commented Dec 24, 2024

Overview

Upgrades the expo version in the expo-video-sample app to 52

  • Fixes android issues: duplicated image resources with *.webp extension
> Task :app:mergeDebugResources FAILED
ERROR: [mipmap-mdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-mdpi/ic_launcher.webp [mipmap-mdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-mdpi/ic_launcher.png: Resource and asset merger: Duplicate resources
ERROR: [mipmap-mdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-mdpi/ic_launcher_round.png [mipmap-mdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-mdpi/ic_launcher_round.webp: Resource and asset merger: Duplicate resources
ERROR: [mipmap-hdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-hdpi/ic_launcher.webp [mipmap-hdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-hdpi/ic_launcher.png: Resource and asset merger: Duplicate resources
ERROR: [mipmap-hdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-hdpi/ic_launcher_round.png [mipmap-hdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-hdpi/ic_launcher_round.webp: Resource and asset merger: Duplicate resources
ERROR: [mipmap-xxxhdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.webp [mipmap-xxxhdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png: Resource and asset merger: Duplicate resources
ERROR: [mipmap-xxxhdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png [mipmap-xxxhdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.webp: Resource and asset merger: Duplicate resources
ERROR: [mipmap-xxhdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xxhdpi/ic_launcher.webp [mipmap-xxhdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xxhdpi/ic_launcher.png: Resource and asset merger: Duplicate resources
ERROR: [mipmap-xxhdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png [mipmap-xxhdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.webp: Resource and asset merger: Duplicate resources
ERROR: [mipmap-xhdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xhdpi/ic_launcher.webp [mipmap-xhdpi-v4/ic_launcher] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xhdpi/ic_launcher.png: Resource and asset merger: Duplicate resources
ERROR: [mipmap-xhdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xhdpi/ic_launcher_round.png [mipmap-xhdpi-v4/ic_launcher_round] /Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/android/app/src/main/res/mipmap-xhdpi/ic_launcher_round.webp: Resource and asset merger: Duplicate resources
  • Fixes Type incompatibility issues:
error TS2345: Argument of type 'import("/Users/mkristian/Projects/stream/stream-video-js/sample-apps/react-native/expo-video-sample/node_modules/expo-notifications/build/Notifications.types").Notification' is not assignable to parameter of type 'import("/Users/mkristian/Projects/stream/stream-video-js/packages/react-native-sdk/node_modules/expo-notifications/build/Notifications.types").Notification'.
  The types of 'request.trigger' are incompatible between these types.
TS2339: Property 'type' does not exist on type 'number | PushNotificationTrigger | LocationNotificationTrigger | ChannelAwareTriggerInput | ... 8 more ... | UnknownNotificationTrigger'.
[@stream-io/video-react-native-sdk]:   Property 'type' does not exist on type 'number'.
[@stream-io/video-react-native-sdk]:
[@stream-io/video-react-native-sdk]: 38     if (event.request.trigger?.type === 'push') {

To solve these issues we needed to:

  • bump the react-native-sdk expo-notification version to "expo-notifications": "~0.29.11" to be in sync with the one used in the expo-video-sample app.
  • create new isPushNotification util method to do the type checks

@kristian-mkd kristian-mkd changed the title fix(rn-video): upgrade to expo ver 52 chore(rn-video): upgrade to expo ver 52 Dec 24, 2024
@kristian-mkd kristian-mkd merged commit 7eec9b0 into main Jan 3, 2025
10 checks passed
@kristian-mkd kristian-mkd deleted the expo-52-new branch January 3, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants