Merge pull request #479 from GetStream/empty-channel-last-read-message

fix: selecting empty channel
GetStream · Sep 25, 2023 · 85eccdc · 85eccdc
2 parents 1f20464 + b25884f
commit 85eccdc
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/projects/stream-chat-angular/src/lib/channel.service.spec.ts b/projects/stream-chat-angular/src/lib/channel.service.spec.ts
@@ -2033,4 +2033,19 @@ describe('ChannelService', () => {
 
     expect(service.activeChannelLastReadMessageId).toBe(undefined);
   });
+
+  it('should be able to select empty channel as active channel', () => {
+    const channel = generateMockChannels()[0];
+    channel.id = 'new-empty-channel';
+    channel.state.messages = [];
+    channel.state.latestMessages = [];
+
+    service.setAsActiveChannel(channel);
+
+    const spy = jasmine.createSpy();
+    service.activeChannel$.subscribe(spy);
+
+    expect(spy).toHaveBeenCalledWith(channel);
+    expect(service.activeChannelLastReadMessageId).toBeUndefined();
+  });
 });
diff --git a/projects/stream-chat-angular/src/lib/channel.service.ts b/projects/stream-chat-angular/src/lib/channel.service.ts
@@ -422,7 +422,7 @@ export class ChannelService<
       ]?.last_read_message_id;
     if (
       channel.state.latestMessages[channel.state.latestMessages.length - 1]
-        .id === this.activeChannelLastReadMessageId
+        ?.id === this.activeChannelLastReadMessageId
     ) {
       this.activeChannelLastReadMessageId = undefined;
     }