-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpennNI 2 driver #4
base: master
Are you sure you want to change the base?
Conversation
I've tested this with my Xtion and it works pretty well. |
} | ||
|
||
// Enable color-to-depth synchronization | ||
status = device.setDepthColorSyncEnabled(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the parameter here be 'true' to enable synchronisation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch.
Hi, Thank you for the nice contribution. It is very clean, and I am pretty happy to include it. I only would like to have a different integration into the build system. We try to use the CMake file as the real build system. The make file is just there for my own quick hacking and I would like to just keep it in the short form it is now. Would you mind updating your pull request with an updated CMakeLists.txt file to build your driver? cheers, |
Yes, but it will take a while since I first have to finish some other 3D scanning stuff :) |
No worries, I am also too busy right now. If I get some time, I will pull in your code commits individually. |
I added OpenNI 2 support, which allows using KFusion with the Asus Xtion and other Primesense devices.
I also included a few other fixes and changed the Makefile so that the C++ compiler, include paths etc. can be set from outside the Makefile and don't need to be hardcoded.
My OpenNI error handling is rigorous but verbose. Tell me if you would prefer a macro instead to make calls+checks one-liners.