Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] Fix missing languages for 'published' field on Touristic Content in APIv2 (#4439) #4440

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Jan 6, 2025

Description

Related Issue

#4439

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Jan 6, 2025

Geotrek-admin    Run #10705

Run Properties:  status check passed Passed #10705  •  git commit b8b886b66b ℹ️: Merge 3d889a4d6653963747f4ff4f80bb9806e3d9d014 into 4dba2fb8f4dbf97c182d9c27228f...
Project Geotrek-admin
Branch Review refs/pull/4440/merge
Run status status check passed Passed #10705
Run duration 02m 07s
Commit git commit b8b886b66b ℹ️: Merge 3d889a4d6653963747f4ff4f80bb9806e3d9d014 into 4dba2fb8f4dbf97c182d9c27228f...
Committer Célia
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (4dba2fb) to head (3d889a4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4440   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         268      268           
  Lines       21290    21293    +3     
=======================================
+ Hits        20964    20967    +3     
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant