GSLUX-686: Profil component #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-686-profil-component/ |
AlitaBernachot
force-pushed
the
GSLUX-686-profil-component
branch
8 times, most recently
from
79acd7c
to
2c7eb84
Compare
AlitaBernachot
force-pushed
the
GSLUX-686-profil-component
branch
2 times, most recently
from
ea01eac
to
ef269b0
Compare
tkohr
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Pfiou, big work, clean architecture, thanks @AlitaBernachot ! I just left minor questions and suggestions inline. Works fine in v4 :-) Don't forget to rebase.
src/components/feature-elevation-profile/feature-elevation-profil.spec.ts
Outdated
Show resolved
Hide resolved
src/components/feature-elevation-profile/feature-elevation-profile.vue
Outdated
Show resolved
Hide resolved
AlitaBernachot
force-pushed
the
GSLUX-686-profil-component
branch
from
ef269b0
to
51359c5
Compare
tkohr
reviewed
Nov 21, 2024
AlitaBernachot
force-pushed
the
GSLUX-686-profil-component
branch
from
951506e
to
0eb468d
Compare
AlitaBernachot
force-pushed
the
GSLUX-686-profil-component
branch
from
338b74b
to
005f394
Compare
|
Thanks for the adaptions @AlitaBernachot! Hover pointer now also shows up in v3, just a little slow on my side, but my chromium currently a little slow in general. Firefox is fluid on my side, which just made me notice that the hovering seems to stay active on the line when selecting another (point) geometry, for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-686
Description
Improve Profile component:
For v3 Geoportail-Luxembourg/geoportailv3#3198