Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate to artifacts v4 #306

Merged
merged 1 commit into from
Oct 13, 2024
Merged

fix: migrate to artifacts v4 #306

merged 1 commit into from
Oct 13, 2024

Conversation

wilsonjord
Copy link
Contributor

@wilsonjord wilsonjord commented Oct 10, 2024

This PR migrates reusable workflows from upload/download artifacts v3 to v4.
v4 represents breaking changes: https://github.blog/news-insights/product-news/get-started-with-v4-of-github-actions-artifacts/#compatibility
To summarise:

  • no longer upload the same named artifact more than once (PR fix: uses overwrite: true to maintain current behaviour)
  • can only use download v4 to access artifacts uploaded with v4 (from code search, appears to be no case of a workflow using v3 to download an artifact produced by the reusables)

This PR should maintain current behaviour, and not break any existing workflows.

@wilsonjord wilsonjord self-assigned this Oct 10, 2024
Move from v3 to v4 of upload-artifact / download-artifact
@wilsonjord wilsonjord marked this pull request as ready for review October 13, 2024 23:43
@Mossman1215
Copy link
Contributor

yup I'm willing to give that a go

@wilsonjord wilsonjord merged commit 12c9a58 into main Oct 13, 2024
16 checks passed
@wilsonjord wilsonjord deleted the nfc-artifacts4 branch October 13, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants