Support Kitkat #3341

consp1racy · 2022-06-20T08:49:22Z

This is another attempt at suporting API 19. We're developing for a market that's often stuck 10 years ago and seeing this work felt amazing. Maybe label it as experimental.

What this consists of:

Rebase the original api19 branch on top of master.
Polyfill android.system.Os.write(FileDescriptor, ByteBuffer).
Backport MediaCodec.getOutputBuffer API.
Set ANDROID_HOME=/data/local/tmp for server.

What doesn't work:

Emulators. See https://issuetracker.google.com/issues/36982354
~~Philips 10BDL3051T (no root). See android watch (Android 4) not showing up #98 (comment)~~

What definitely works:

HTC Desire 601(rooted)
Philips 10BDL3051 (no root) with the ANDROID_DATA hack

The performance isn't amazing but it works.

Since "adb forward" fallback has been implemented, it is easy to support API 19. Replace the incompatible calls related to MediaCodec to use minSdkVersion 19 instead of 21.

rom1v

Thank you for your work.

I guess you followed #98 discussions. After re-reading it, when I concluded:

The video encoder does not work below 5.0.

Maybe it was related to the smart watch from the issue (without an hardware encoder) and not to Android < 5 after all. So indeed, it might be possible to support Android 4.4.

TBH, I'm not sure it's worth it to add support for 4.4 in 2022. It adds complexity and maintenance (btw there is still probably the dalvik-cache creation to handle). But if it works, maybe we could merge (anyway at least a separate up-to-date api19 branch could be useful)… I have no Android 4.4 device to test unfortunately. I will try to find one.

rom1v · 2022-06-20T19:25:17Z

server/build.gradle

@@ -21,6 +21,7 @@ android {
 dependencies {
    implementation fileTree(dir: 'libs', include: ['*.jar'])
    testImplementation 'junit:junit:4.13.1'
+    compileOnly 'androidx.annotation:annotation:1.3.0' // 1.3.0 doesn't depend on Kotlin stdlib.


Nope, the server should be buildable without any java/kotlin dependencies (and without gradle): build_without_gradle.sh

(Btw, I just removed the implementation fileTree line above: 7f2f595)

Hmm, is it OK to download a prebuilt into a directory (e.g. prebuilt-compileOnly) and also use everything in it as classpath for javac? That should work both ways. I really want the IDE to help me not call API 19 stuff on API 21.

and without gradle

Any other reason than using build system within build system is weird? (And the flex of knowing how to manually produce an APK? 😁 )

is it OK to download a prebuilt into a directory

Nope. If it was a necessary dependency, we could discuss what to do, but here they are just annotations, it does not worth the dependency.

Any other reason than using build system within build system is weird?

It is used to build the official Debian package: https://salsa.debian.org/yangfl-guest/scrcpy/-/blob/ab5d09e733bb9635b4410693ceff95dbc859dd4c/debian/rules#L41
There were problems with gradle/kotlin (Debian provides its own packages for android tools), and it is not acceptable for Debian to download dependencies while building (there must be a separate package built from sources…).

I only want @RequiresApi, Android Studio will probably be happy if we just include this one class in the project. Then we don't need to manage a dependency.

server/src/main/java/android/system/Os.java

server/src/main/java/com/genymobile/scrcpy/MediaCodecCompat.java

Don't manage an external dependency, we still need to be able to build without gradle.

consp1racy · 2022-06-25T14:38:11Z

I've made it so the AndroidX annotation-1.3.0.jar lives as a copy inside the repo. It's a compile-only dependency both in server/build.gradle and server/build_without_gradle.sh. That way it contributes to developer experience in Android Studio, it contributes to lint, but has no effect on the produced artifact. The annotations and their calls are not present scrcpy-server binary.

The same thing now applies to the libcore.io package. This package is part of the framework and only needs to be presetn at compile time. The binary doesn't contain any of these classes.

~~The same approach should be done in the future with the system AIDL interfaces (e.g. IRotationWatcher.aidl or IClipboard) these are part of the framework and shouldn't be part of the binary.~~ This only applies to gradle build.

android.system package remains shadowed for now. ~~Tried doing it better but it bloated the binary.~~

Removed unnecessary logic from MediaCodecCompat.

Extracted MediaCodecListCompat from ScreenEncoder to keep it clean.

consp1racy · 2022-06-27T02:58:17Z

We no longer shadow android.system package. Instead there's new androidx.system package.
OsCompat.write(FileDescriptor, ByteBuffer) now advances buffer position on all platforms. This was fixed in Lollopop MR1. This is no longer part of IO.writeFully.
OsCompat.write automatically retries on EINTR.
As a side-effect, we can now use lambdas.

This wraps up API 19 support. I think devices without an encoder, like the watch, should be handled separately, by querying PackageManager features or listing media codecs and failing with better error message.

This fixes javac call for Windows.

So that we don't shadow framework classes in our binary. Update buffer position in OsCompat.write (fixed in Lollipop MR1). Synthesize InterruptedIOException in Kitkat like in Lollipop. OsCompat never throws EINTR errno.

consp1racy · 2022-06-27T15:07:33Z

Make the /data/local/tmp/dalvik-cache directory ourselves.

We need a path that is writable by shell on Android 4. Genymobile#98 (comment)

yume-chan · 2023-02-03T18:50:27Z

Why the video socket is using file descriptors, not standard Java streams? Is file descriptor faster than stream or something?

consp1racy · 2023-02-03T20:46:02Z

Why the video socket is using file descriptors, not standard Java streams? Is file descriptor faster than stream or something?

66def38

hebing0305 · 2024-04-07T01:33:36Z

I really need it. How can I download it?

Support Android API 19

02b72e6

Since "adb forward" fallback has been implemented, it is easy to support API 19. Replace the incompatible calls related to MediaCodec to use minSdkVersion 19 instead of 21.

consp1racy changed the title ~~Support Kitkat~~ WIP: Support Kitkat Jun 20, 2022

rom1v reviewed Jun 20, 2022

View reviewed changes

consp1racy added 4 commits June 25, 2022 15:38

Use prebuilt AndroidX annotations useful during development

400fa60

Don't manage an external dependency, we still need to be able to build without gradle.

Re-implement subset of android.system package for API 19

2460552

Extract MediaCodecCompat from ScreenEncoder

48cdbb2

Extract MediaCodecListCompat from ScreenEncoder

953ba10

consp1racy force-pushed the api19 branch from 10eac04 to e1d1037 Compare June 25, 2022 13:53

consp1racy force-pushed the api19 branch from e123efb to 82aa3ea Compare June 27, 2022 02:50

consp1racy changed the title ~~WIP: Support Kitkat~~ Support Kitkat Jun 27, 2022

consp1racy added 4 commits June 27, 2022 17:06

Extract MediaCodecListCompat.getEncoderInfosForType

042af5c

Manually set javac encoding in build_without_gradle.sh

ed37ff8

This fixes javac call for Windows.

Add ScreenEncoder.MIMETYPE_VIDEO_AVC to shut up lint on API 19

c57ff1d

consp1racy force-pushed the api19 branch from 82aa3ea to ed9617e Compare June 27, 2022 15:06

Override ANDROID_DATA in server

d535bc9

We need a path that is writable by shell on Android 4. Genymobile#98 (comment)

consp1racy force-pushed the api19 branch from ed9617e to d535bc9 Compare June 27, 2022 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Kitkat #3341

Support Kitkat #3341

consp1racy commented Jun 20, 2022 •

edited

Loading

rom1v left a comment

rom1v Jun 20, 2022

consp1racy Jun 21, 2022

rom1v Jun 21, 2022 •

edited

Loading

consp1racy Jun 21, 2022

consp1racy commented Jun 25, 2022 •

edited

Loading

consp1racy commented Jun 27, 2022 •

edited

Loading

consp1racy commented Jun 27, 2022

yume-chan commented Feb 3, 2023

consp1racy commented Feb 3, 2023

hebing0305 commented Apr 7, 2024

Support Kitkat #3341

Are you sure you want to change the base?

Support Kitkat #3341

Conversation

consp1racy commented Jun 20, 2022 • edited Loading

rom1v left a comment

Choose a reason for hiding this comment

rom1v Jun 20, 2022

Choose a reason for hiding this comment

consp1racy Jun 21, 2022

Choose a reason for hiding this comment

rom1v Jun 21, 2022 • edited Loading

Choose a reason for hiding this comment

consp1racy Jun 21, 2022

Choose a reason for hiding this comment

consp1racy commented Jun 25, 2022 • edited Loading

consp1racy commented Jun 27, 2022 • edited Loading

consp1racy commented Jun 27, 2022

yume-chan commented Feb 3, 2023

consp1racy commented Feb 3, 2023

hebing0305 commented Apr 7, 2024

consp1racy commented Jun 20, 2022 •

edited

Loading

rom1v Jun 21, 2022 •

edited

Loading

consp1racy commented Jun 25, 2022 •

edited

Loading

consp1racy commented Jun 27, 2022 •

edited

Loading