Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAYER-38] change HTML parent element of mouseevent listener plugin #93

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

jparez
Copy link
Contributor

@jparez jparez commented Aug 7, 2024

Description

fix bug when clicking on the icon of the resolution plugin, the selectbox wasn't displayed

Element of the listener wasn't correct

@jparez jparez requested a review from pgivel August 7, 2024 08:37
Copy link
Contributor

@pgivel pgivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is OK but it will need to be validated on shadow

@jparez jparez merged commit c11235a into main Aug 7, 2024
1 check passed
@jparez jparez deleted the dev/PLAYER-38-fix-issue-on-click-resolution branch August 7, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants