Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAYER-40] delete template feature #114

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[PLAYER-40] delete template feature #114

merged 2 commits into from
Nov 25, 2024

Conversation

jparez
Copy link
Contributor

@jparez jparez commented Nov 15, 2024 •
edited
Loading

Description

The main purpose of this PR is to remove the template system.

  • Removed the template feature and replaced it with a simple HTML structure.
  • Fixed the alignment of the grid for the activateGrid keymapping API.
  • Changed how the loader is handled when a stream isn't available.
  • Added an option to show a frame over the video stream to mimic a phone style.
  • Deleted the template folders.

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes.

@jparez jparez requested a review from pgivel November 15, 2024 13:08
pgivel
pgivel approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@pgivel pgivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 ❤️

src/DeviceRendererFactory.js

// Handle template dom
dom.innerHTML = template.html;
loadTemplate(dom, options) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shadow should only need to override this function I guess?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and inject their own HTML. I wonder if it would be more logical to move loadTemplate to DeviceRenderer.js

@jparez jparez merged commit 08dd6fd into main Nov 25, 2024
1 check passed
@jparez jparez deleted the dev/PLAYER-40-delete-template-feature branch November 25, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgivel pgivel pgivel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jparez @pgivel