Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace way of check if plugin charged #100

Merged
merged 1 commit into from
Sep 10, 2024
Merged

replace way of check if plugin charged #100

merged 1 commit into from
Sep 10, 2024

Conversation

jparez
Copy link
Contributor

@jparez jparez commented Sep 10, 2024

Description

When player is used in third party app class.name could be empty in case of uglify process on node modules

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@jparez jparez requested a review from pgivel September 10, 2024 12:04
pgivel
pgivel approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@pgivel pgivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a good enough solution :)

@jparez jparez merged commit a799c63 into main Sep 10, 2024
1 check passed
@jparez jparez deleted the fix/change-check-for-not-load-plugin-dependency-twice branch September 10, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgivel pgivel pgivel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jparez @pgivel