Skip to content

Commit

Permalink
parse placeholders to eliminate errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Adrian Salceanu committed Oct 28, 2021
1 parent 2ff71de commit b8100a2
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/Tables.jl
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,11 @@ function Base.parse(::Type{DataTablePagination}, d::Dict{String,Any})
dtp
end

function Base.parse(::Type{DataTable{DataFrames.DataFrame}}, d::Dict{String,Any})
function Base.parse(::Type{DataTable}, ::Dict{String,Any})
# todo: add support
end

function Base.parse(::Type{DataTable{DataFrames.DataFrame}}, ::Dict{String,Any})
# error("Not implemented") # todo implement parser
end

Expand Down

4 comments on commit b8100a2

@essenciary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/47939

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.10.0 -m "<description of version>" b8100a2d3e1e7b4035ff3791dc0d1c289ceded3d
git push origin v0.10.0

@essenciary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/47939

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.10.0 -m "<description of version>" b8100a2d3e1e7b4035ff3791dc0d1c289ceded3d
git push origin v0.10.0

Please sign in to comment.