-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ReactiveTools macros @app
, @handlers
and @init
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variable section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the call of the ReactiveTools macros
@app
,@handlers
,@type
,@in
, etc. violate the no-side-kick principle of macros, i.e. they change the state of the program even when called with@macroexpand
.This generated strange interaction with Revise in one case.
This PR refactors all macros such that the code generated can be viewed by
@macroexpand
ing the calls.Here's a list of changes:
@app
,@handlers
and@init
have been refactored and greatly simplified@var
only supports one API, support of explicit reactive types has been deprecated@in
,@out
etc, have been removed, the parsing of the macro expressions is performed by the@handlers
macro@handlers
macro is called without a variable section, it will not change the existing app declaration, but only add a handler; when called with a variable section, these variables will overwrite former variables and no longer add them. As before, the resulting handlers function is registered as default handler for that is called by@init
This PR could be a first step of a potential deprecation of implicit models; explicit models have the large advantage that multiple apps can live in one module and that they can easily share code. Moreover, they are necessary to build multi-app pages, for which another PR is in preparation #299.