Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add light/dark theme with theme switch injected in page (wip) #277

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

protozoo
Copy link
Member

A proposal for integrating light and dark default themes, including a theme-switch button.
There are a few things to consider here:

  1. In Genie apps, Quasar's css (quasar.min.css) is added after stipplecore.css. This overrides some rules from stipplecore.css. So by now I made the affected properties "!important" in stipplecore.css, but that's not ideal. Would it make sense to make the necessary changes (in StippleUI?) to reverse the load order of these two css files?
  2. The theme-switch button gets injected in the page dynamically with a function I added to stipplecore.js. Maybe there's a better place/way to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants