Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description of TDR setting parameters in Tutorial 1 #793

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

lbonaldo
Copy link
Collaborator

Description

Addresses #786: Set TimeDomainReduction parameter to 1 to enable TDR.

What type of PR is this? (check all applicable)

  • Documentation Update

Related Tickets & Documents

Fixes #786

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

By reviewing the Tutorial_1_configuring_settings page inside the Tutorial folder of the documentation.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

Copy link
Collaborator

@sambuddhac sambuddhac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved !!!

@lbonaldo lbonaldo merged commit f1bbba4 into develop Nov 19, 2024
9 checks passed
@lbonaldo lbonaldo deleted the 786-question-binary-parameter-timedomainreduction branch November 19, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants