Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds automatic problem scaling using MacroEnergySystemsScaling.jl package. This allows the ParameterScale features to be removed.
While full reformulation of a model is preferable to using scaling, this is not feasible in the workflow that most users go through in building and running GenX models. By calling
scale_constraints!(EP)
, MacroEnergySystemsScaling.jl will re-scale all constraints so that the variable coefficients and right-hand side constants are within user-specified bounds. This usually improves the numerical stability, and occasionally runtime, of a model.This PR:
1_three_zones
example. It is not present in the others.ParameterScale
andscale_factor
, and updated the documentation correspondingly.Note, MacroEnergySystemsScaling.jl does not appear to work well with JuMP direct_model(). It only works well with JuMP Model(), which is currently what GenX uses to create models.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Checklist
How this can be tested
To test this, I recommend
Post-approval checklist for GenX core developers
After the PR is approved