-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure multistage settings #703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
JuliaFormatter
src/write_outputs/ucommit/write_start.jl|20|
src/write_outputs/write_charge.jl|46|
src/write_outputs/write_charge.jl|48|
src/write_outputs/write_charge.jl|54|
src/write_outputs/write_co2.jl|37|
src/write_outputs/write_co2.jl|39|
src/write_outputs/write_curtailment.jl|62|
src/write_outputs/write_curtailment.jl|64|
src/write_outputs/write_emissions.jl|130|
src/write_outputs/write_emissions.jl|132|
src/write_outputs/write_fuel_consumption.jl|91|
src/write_outputs/write_fuel_consumption.jl|93|
src/write_outputs/write_nse.jl|42|
src/write_outputs/write_outputs.jl|27|
src/write_outputs/write_power.jl|29|
src/write_outputs/write_power.jl|31|
src/write_outputs/write_power_balance.jl|101|
src/write_outputs/write_power_balance.jl|104|
src/write_outputs/write_power_balance.jl|106|
src/write_outputs/write_price.jl|28|
src/write_outputs/write_reliability.jl|27|
src/write_outputs/write_storage.jl|45|
src/write_outputs/write_storage.jl|47|
src/write_outputs/write_storagedual.jl|85|
src/write_outputs/write_storagedual.jl|87|
7f87782
to
8f48635
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mmutic!
Description
This PR adds default settings for the multistage feature of GenX. It adds a file called configure_settings_multistage, and calls the function in that file in run_genx_multistage so that users no longer need to specify all multistage settings in order to run a multistage case.
What type of PR is this? (check all applicable)
Related Tickets & Documents
This is related to Issue #658 but does not directly fix it (another PR will address that issue).
Checklist
How this can be tested
To test this, I deleted the multistage settings dictionary in example 6 (multistage) to see if GenX would still run successfully and it did. Note that the file still needs to be present, but does not need to have anything in it.
Post-approval checklist for GenX core developers
After the PR is approved