Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fuel cols in vre and stor csvs in examples #684

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Apr 15, 2024

Description

This PR removes some unnecessary columns in the Vre.csv and Storage.csv files of the example cases.

What type of PR is this? (check all applicable)

  • Example cleanup

Related Tickets & Documents

Addresses #674.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

By running the test_examples.jl file inside the test folder, or by running the examples separately.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@lbonaldo lbonaldo requested a review from sambuddhac April 15, 2024 18:48
@lbonaldo lbonaldo merged commit aa0e0ef into GenXProject:release/0.4.0 Apr 16, 2024
7 checks passed
@lbonaldo lbonaldo deleted the fix-vre_examples branch April 16, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants