Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discount cUnmetPolicyPenalty in write_multi_stage_cost.jl #679

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Apr 9, 2024

Description

Add discount with OPEX multipliers to cUnmetPolicyPenalty in write_multi_stage_cost.jl.
This should fix #623.

What type of PR is this? (check all applicable)

  • Bug Fix

Related Tickets & Documents

#623

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Tested on the multistage example.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@lbonaldo lbonaldo requested a review from filippopecci April 9, 2024 16:12
@lbonaldo lbonaldo added the bug Something isn't working label Apr 9, 2024
@lbonaldo lbonaldo added this to the v0.4 milestone Apr 9, 2024
@lbonaldo lbonaldo self-assigned this Apr 9, 2024
@lbonaldo lbonaldo changed the title Dicount cUnmetPolicyPenalty in write_multi_stage_cost.jl Discount cUnmetPolicyPenalty in write_multi_stage_cost.jl Apr 9, 2024
@lbonaldo lbonaldo merged commit a047697 into GenXProject:release/0.4.0 Apr 9, 2024
6 of 7 checks passed
@lbonaldo lbonaldo deleted the fix-623 branch April 9, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multistage Costs do not apply OPEXMULT discount factor to UnmetPolicyPenalty
2 participants