New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add electrolyzer to current VRE_STOR #678

Merged

lbonaldo merged 74 commits into develop from elec_colocation_new

Jul 23, 2024

Collaborator

qluo0320github commented Apr 9, 2024 •

edited by lbonaldo

Loading

Description

Add a new component to VER-STOR, enabling electrolyzer to use off-grid VRE-STOR to produce hydrogen

What type of PR is this? (check all applicable)

Feature

Related Tickets & Documents

Checklist

Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
Code has been tested to ensure all functionality works as intended.
CHANGELOG.md has been updated (if this is a 'notable' change).
I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

A new example case was create to test it. Additionally, it passed tests for all example cases

Post-approval checklist for GenX core developers

After the PR is approved

Check that the latest changes on the target branch are incorporated, either via merge or rebase
Remember to squash and merge if incorporating into develop

qluo0320github requested a review from lbonaldo

April 9, 2024 13:52

qluo0320github marked this pull request as draft

April 9, 2024 13:52

qluo0320github requested a review from gmantegna

April 9, 2024 13:53

lbonaldo added this to the v0.4.1 milestone

lbonaldo force-pushed the elec_colocation_new branch from 5d00623 to 60fac0e Compare

June 27, 2024 21:45

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/model/resources/vre_stor/vre_stor.jl|1395|
src/model/resources/vre_stor/vre_stor.jl|1411|
src/model/resources/vre_stor/vre_stor.jl|1413|
src/model/resources/vre_stor/vre_stor.jl|1419|
src/model/resources/vre_stor/vre_stor.jl|1427|
src/model/resources/vre_stor/vre_stor.jl|1437|
src/model/resources/vre_stor/vre_stor.jl|1442|
src/model/resources/vre_stor/vre_stor.jl|1444|
src/model/resources/vre_stor/vre_stor.jl|1449|
src/model/resources/vre_stor/vre_stor.jl|1453|
src/model/resources/vre_stor/vre_stor.jl|1466|
src/model/resources/vre_stor/vre_stor.jl|1474|
src/multi_stage/configure_multi_stage_inputs.jl|140|
src/multi_stage/configure_multi_stage_inputs.jl|171|
src/multi_stage/endogenous_retirement.jl|47|
src/multi_stage/endogenous_retirement.jl|64|
src/multi_stage/endogenous_retirement.jl|116|
src/multi_stage/endogenous_retirement.jl|121|
src/multi_stage/endogenous_retirement.jl|601|
src/multi_stage/endogenous_retirement.jl|603|
src/multi_stage/endogenous_retirement.jl|607|
src/multi_stage/endogenous_retirement.jl|610|
src/multi_stage/endogenous_retirement.jl|612|
src/multi_stage/endogenous_retirement.jl|616|
src/multi_stage/endogenous_retirement.jl|618|
src/multi_stage/endogenous_retirement.jl|626|
src/multi_stage/endogenous_retirement.jl|628|
src/multi_stage/endogenous_retirement.jl|633|
src/multi_stage/endogenous_retirement.jl|635|
src/multi_stage/endogenous_retirement.jl|640|
src/multi_stage/endogenous_retirement.jl|645|
src/multi_stage/endogenous_retirement.jl|648|
src/multi_stage/endogenous_retirement.jl|651|
src/write_outputs/hydrogen/write_hydrogen_prices.jl|2|
src/write_outputs/hydrogen/write_hydrogen_prices.jl|7|
src/write_outputs/hydrogen/write_hydrogen_prices.jl|13|
src/write_outputs/write_capacityfactor.jl|69|
src/write_outputs/write_charge.jl|31|
src/write_outputs/write_charging_cost.jl|32|
src/write_outputs/write_costs.jl|7|
src/write_outputs/write_costs.jl|39|
src/write_outputs/write_costs.jl|185|
src/write_outputs/write_costs.jl|219|
src/write_outputs/write_costs.jl|330|
src/write_outputs/write_outputs.jl|430|
src/write_outputs/write_power_balance.jl|64|
src/write_outputs/write_power_balance.jl|72|
src/write_outputs/write_vre_stor.jl|29|
src/write_outputs/write_vre_stor.jl|48|
src/write_outputs/write_vre_stor.jl|53|
src/write_outputs/write_vre_stor.jl|110|
src/write_outputs/write_vre_stor.jl|121|
src/write_outputs/write_vre_stor.jl|123|
src/write_outputs/write_vre_stor.jl|215|
src/write_outputs/write_vre_stor.jl|260|
src/write_outputs/write_vre_stor.jl|304|
src/write_outputs/write_vre_stor.jl|402|
src/write_outputs/write_vre_stor.jl|464|
src/write_outputs/write_vre_stor.jl|481|
test/test_electrolyzer.jl|16|

example_systems/8_three_zones_w_colocated_VRE_storage_electrolyzers/Run.jl Show resolved Hide resolved

src/model/resources/vre_stor/vre_stor.jl Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/multi_stage/endogenous_retirement.jl|628|
src/multi_stage/endogenous_retirement.jl|633|
src/multi_stage/endogenous_retirement.jl|635|
src/multi_stage/endogenous_retirement.jl|640|
src/multi_stage/endogenous_retirement.jl|645|
src/multi_stage/endogenous_retirement.jl|648|
src/multi_stage/endogenous_retirement.jl|651|
src/write_outputs/hydrogen/write_hydrogen_prices.jl|2|
src/write_outputs/hydrogen/write_hydrogen_prices.jl|7|
src/write_outputs/hydrogen/write_hydrogen_prices.jl|13|
src/write_outputs/write_capacityfactor.jl|69|
src/write_outputs/write_charge.jl|31|
src/write_outputs/write_charging_cost.jl|32|
src/write_outputs/write_costs.jl|7|
src/write_outputs/write_costs.jl|39|
src/write_outputs/write_costs.jl|185|
src/write_outputs/write_costs.jl|219|
src/write_outputs/write_costs.jl|330|
src/write_outputs/write_outputs.jl|430|
src/write_outputs/write_power_balance.jl|64|
src/write_outputs/write_power_balance.jl|72|
src/write_outputs/write_vre_stor.jl|29|
src/write_outputs/write_vre_stor.jl|48|
src/write_outputs/write_vre_stor.jl|53|
src/write_outputs/write_vre_stor.jl|110|
src/write_outputs/write_vre_stor.jl|121|
src/write_outputs/write_vre_stor.jl|123|
src/write_outputs/write_vre_stor.jl|215|
src/write_outputs/write_vre_stor.jl|260|
src/write_outputs/write_vre_stor.jl|304|
src/write_outputs/write_vre_stor.jl|402|
src/write_outputs/write_vre_stor.jl|464|
src/write_outputs/write_vre_stor.jl|481|
test/test_electrolyzer.jl|16|

src/multi_stage/endogenous_retirement.jl Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/write_outputs/write_vre_stor.jl|121|
src/write_outputs/write_vre_stor.jl|123|
src/write_outputs/write_vre_stor.jl|215|
src/write_outputs/write_vre_stor.jl|260|
src/write_outputs/write_vre_stor.jl|304|
src/write_outputs/write_vre_stor.jl|402|
src/write_outputs/write_vre_stor.jl|464|
src/write_outputs/write_vre_stor.jl|481|
test/test_electrolyzer.jl|16|

src/write_outputs/write_power_balance.jl Outdated Show resolved Hide resolved

src/write_outputs/write_vre_stor.jl Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/write_outputs/write_vre_stor.jl|215|
src/write_outputs/write_vre_stor.jl|260|
src/write_outputs/write_vre_stor.jl|304|
src/write_outputs/write_vre_stor.jl|402|
src/write_outputs/write_vre_stor.jl|464|
src/write_outputs/write_vre_stor.jl|481|
test/test_electrolyzer.jl|16|

src/write_outputs/write_vre_stor.jl Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/write_outputs/write_vre_stor.jl|121|
src/write_outputs/write_vre_stor.jl|123|
src/write_outputs/write_vre_stor.jl|215|
src/write_outputs/write_vre_stor.jl|260|
src/write_outputs/write_vre_stor.jl|304|
src/write_outputs/write_vre_stor.jl|402|
src/write_outputs/write_vre_stor.jl|464|
src/write_outputs/write_vre_stor.jl|481|
test/test_electrolyzer.jl|16|

src/write_outputs/write_power_balance.jl Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/write_outputs/write_vre_stor.jl|123|
src/write_outputs/write_vre_stor.jl|215|
src/write_outputs/write_vre_stor.jl|260|
src/write_outputs/write_vre_stor.jl|304|
src/write_outputs/write_vre_stor.jl|402|
src/write_outputs/write_vre_stor.jl|464|
src/write_outputs/write_vre_stor.jl|481|
test/test_electrolyzer.jl|16|

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/write_outputs/write_vre_stor.jl|215|
src/write_outputs/write_vre_stor.jl|260|
src/write_outputs/write_vre_stor.jl|304|
src/write_outputs/write_vre_stor.jl|402|
src/write_outputs/write_vre_stor.jl|464|
src/write_outputs/write_vre_stor.jl|481|
test/test_electrolyzer.jl|16|

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/write_outputs/write_vre_stor.jl|305|
src/write_outputs/write_vre_stor.jl|403|
src/write_outputs/write_vre_stor.jl|465|
src/write_outputs/write_vre_stor.jl|482|
test/test_electrolyzer.jl|16|

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/write_outputs/write_vre_stor.jl|465|
src/write_outputs/write_vre_stor.jl|482|
test/test_electrolyzer.jl|16|

qluo0320github and others added 16 commits

July 2, 2024 14:40


          add electrolyzer module to VRE_STOR

092e865


          Enable colocation of electrolyzers in multi stage

b910f74


          move hydrogen demand to policies

d4801a4


          update the condition of using electrolyzers

24099b0


          Add hydrogen settings to test

1e10cc8


          Change capacity unit for VS_ELEC to AC in doc

f6a8bb5


          modify CHANGE.LOG

39799d8


          add electrolyzer module to VRE_STOR

7e012cc


          Enable colocation of electrolyzers in multi stage

0c892dc


          Rename examples 9 and 10.

0ebdae2


          Change VS_ELEC capacity unit to AC in doc

8e52475


          Enable regional H2 demand requirement in policies

c5e5fa8


          Remove the resource-level hydrogen requirement

5b278c2


          refactor: Remove redundant code for existing electric capacity in wri…

155fbb5

…te_vre_stor.jl


          refactor: Update configure_multi_stage_inputs to use tech_wacc_elec f…

…or VRE_STOR


          Add scaling of min_retired_elec when loading multistage module

301d644


          Fix formatting endogenous retirement

76746a3

Repository owner deleted a comment from github-actions bot

Repository owner deleted a comment from github-actions bot

Repository owner deleted a comment from github-actions bot

qluo0320github and others added 11 commits

July 18, 2024 15:41


          Enable electrolyzers without H2 demand requirement

b3ebce9


          fix bug in write_costs.jl about electrolyzers

19463d1


          update outputs writing for electrolyzers

0b45f1c


          Clean formatting

94ea721


          Update writing of hydrogen value

bb121a0


          Fix column name in docs

2a63fbc


          Fix if check to allow for short-circuit eval

9d5444d


          Rename function to avoid name clash

914937d


          Update HydrogenHourlyMatching in docs

9ed1f67


          Cleanup electrolyzer.jl

255611a


          Fix formatting

c64c6b2

github-actions bot reviewed

View reviewed changes

src/load_inputs/load_resources_data.jl Show resolved Hide resolved

src/model/resources/hydrogen/electrolyzer.jl Show resolved Hide resolved

src/model/resources/hydrogen/electrolyzer.jl Show resolved Hide resolved

src/write_outputs/write_costs.jl Show resolved Hide resolved

lbonaldo added 3 commits

July 23, 2024 09:37


          Fix write_outputs.jl

bb301a9


          Update CHANGELOG.md

61f5a22


          Update dev branch package version to 0.4.0-dev.13

Repository owner deleted a comment from github-actions bot

lbonaldo added 3 commits

July 23, 2024 09:58


          Escape _ in docs

6ef3b3d


          Fix paths in readmes

d486b27


          Fix comment write_costs.jl

9a4d969

Repository owner deleted a comment from github-actions bot

Repository owner deleted a comment from github-actions bot

lbonaldo marked this pull request as ready for review

July 23, 2024 08:25

lbonaldo self-requested a review

July 23, 2024 08:25

lbonaldo approved these changes

View reviewed changes

Collaborator

lbonaldo left a comment

This PR looks good to me. Thanks @qluo0320github for this new module!

lbonaldo merged commit 52ea33b into develop

11 checks passed

lbonaldo deleted the elec_colocation_new branch

July 23, 2024 08:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet