Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format codebase and add format check to the CI #673

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Apr 1, 2024

Description

This PR:

  • Formats the entire codebase using JuliaFormatter.jl.
  • Introduces a GitHub action that checks the code and provides format suggestions for new PRs, facilitating the maintenance of code formatting standards.

What type of PR is this? (check all applicable)

  • Feature

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@lbonaldo lbonaldo requested a review from sambuddhac April 1, 2024 21:57
@sambuddhac sambuddhac linked an issue Apr 1, 2024 that may be closed by this pull request
@sambuddhac sambuddhac mentioned this pull request Apr 1, 2024
@lbonaldo lbonaldo merged commit ee3f087 into release/0.4.0 Apr 4, 2024
6 of 7 checks passed
@lbonaldo lbonaldo deleted the format-codebase branch April 29, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-format code
2 participants