Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialize_cost_to_go docstring #672

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Apr 1, 2024

This updates the docstring for the initialize_cost_to_go function and adjusts the formula for the discount factor to reflect the code implementation, potentially resolving issue #671.

@lbonaldo lbonaldo requested a review from sambuddhac April 1, 2024 16:53
Copy link
Collaborator

@sambuddhac sambuddhac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring now looks good and in sync with the code.

@sambuddhac sambuddhac merged commit 5dbc6c8 into GenXProject:release/0.4.0 Apr 1, 2024
6 checks passed
@lbonaldo lbonaldo deleted the fix-docs_ddp branch April 1, 2024 17:39
@lbonaldo
Copy link
Collaborator Author

lbonaldo commented Apr 1, 2024

Thank you @sambuddhac!

@sambuddhac
Copy link
Collaborator

You're welcome, @lbonaldo!!! Thanks for the PR and the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-stage optimization with investment periods of varying lengths may result in incorrect discount factors
2 participants