Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scale_factor in write_min/max_capacity_requirement.jl #599

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

cfe316
Copy link
Collaborator

@cfe316 cfe316 commented Dec 8, 2023

Description

This makes the code write_min_capacity and write_max_capacity symmetrical. This is a minor step toward separating the 'currency scale' and 'energy scale'.

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix
  • Documentation Update
  • Code Refactor
  • Performance Improvements

Checklist

  • [n/a] Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • [n/a] CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Tested on RealSystemExample/ISONE_Trizone after creating a MaxCapReq entry. The results are bit-for-bit identical.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@cfe316 cfe316 requested a review from lbonaldo December 8, 2023 22:53
@cfe316 cfe316 merged commit 783f7cd into GenXProject:develop Dec 12, 2023
7 checks passed
@cfe316 cfe316 deleted the refactor-write-min-max-cap-req branch December 12, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants