Minor refactor of write_esr_revenue

[cfe316]

Description

Refactor write_esr_revenue.jl to make it easier to add FUSION in the near future.
Mostly renaming variables, breaking up a long line, and giving a consistent name for multiple accesses.

What type of PR is this? (check all applicable)

• Code Refactor

Checklist

• Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
• The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
• Code has been tested to ensure all functionality works as intended.
• CHANGELOG.md has been updated (if this is a 'notable' change). not notable
• I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Run any case. I tested this on a simple case with two ESR zones. The output is identical.

Post-approval checklist for GenX core developers

After the PR is approved

• Check that the latest changes on the target branch are incorporated, either via merge or rebase
• Remember to squash and merge if incorporating into develop

[lbonaldo]

Thank you, @cfe316!