Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer columns-style network format to matrix format #591

Merged
merged 9 commits into from
Dec 5, 2023
Merged

Prefer columns-style network format to matrix format #591

merged 9 commits into from
Dec 5, 2023

Conversation

cfe316
Copy link
Collaborator

@cfe316 cfe316 commented Dec 3, 2023

This changes the preferred Network input format from a matrix of 1, 0, -1 to lists of Start_Node, End_Node.

  • This may not be perfect: here we use Node, which a more technical term, but in other places in the code and docs we largely use "Zone".

@cfe316 cfe316 requested a review from lbonaldo December 3, 2023 21:48
@cfe316 cfe316 force-pushed the rename-network-list-columns branch from e8b1711 to 803b1f7 Compare December 3, 2023 21:51
@cfe316 cfe316 force-pushed the rename-network-list-columns branch from ca8f21c to c128a15 Compare December 4, 2023 15:05
@cfe316
Copy link
Collaborator Author

cfe316 commented Dec 4, 2023

I've changed back to using Zone.

@cfe316 cfe316 merged commit 54ef23a into GenXProject:develop Dec 5, 2023
5 checks passed
cfe316 added a commit to cfe316/GenX that referenced this pull request Dec 5, 2023
@cfe316
Update changelog for GenXProject#591
4b26421
cfe316 added a commit that referenced this pull request Dec 5, 2023
@cfe316
Update changelog for #591 (#595)
0a35ba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbonaldo lbonaldo lbonaldo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfe316 @lbonaldo