-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tests for seven modules. Include GH workflow. #563
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d884829
Add tests for seven modules. Include GH workflow.
lbonaldo b83a3bf
Add tests for seven modules. Include GH workflow.
lbonaldo 36a5c01
Add rounding to the objective func value in the tests
lbonaldo 9af3ae0
Removed deprecated setup field
lbonaldo 6628a09
Change GH action to push to testlog repo
lbonaldo c6e03d9
Fix permission on ci.yml
lbonaldo 3aadd24
Fix tolerance calculation in tests
lbonaldo a139c29
Fix 'Can_Retire' column and update Multistage test
lbonaldo 1c99326
Update TDR/MoM tests - compare output files
lbonaldo 5ced62e
Fix compatibility with Julia 1.6
lbonaldo 3cc5dea
Update CHANGELOG.md
lbonaldo a556389
Fix setting for tests
lbonaldo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
name: CI | ||
|
||
on: | ||
pull_request: | ||
push: | ||
branches: [main, develop] | ||
tags: ['*'] | ||
|
||
jobs: | ||
test: | ||
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name}} | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
version: | ||
- "1.6" # LTS (64-bit Linux) | ||
- "1.7" | ||
- "1.8" | ||
- '1.9' # latest stable Julia release (Linux) | ||
os: | ||
- ubuntu-latest | ||
arch: | ||
- x64 | ||
include: # additional tests [Julia-nightly] (Linux) | ||
- os: ubuntu-latest | ||
version: 'nightly' | ||
arch: x64 | ||
allow_failure: true | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Create a new branch and pull test logs from repo # only push logs if PR is not from a fork | ||
if: ${{ ! github.event.pull_request.head.repo.fork }} | ||
run: | | ||
git checkout -b ${GITHUB_REF#refs/heads/}-testlogs | ||
mkdir test/Logs; cd test/Logs | ||
git config --global init.defaultBranch main | ||
git init | ||
git config --local user.name GenXProject | ||
git config --local user.email "[email protected]" | ||
git remote add testlog https://[email protected]/GenXProject/GenX-testlog.git | ||
git pull testlog main | ||
if [ -d Logs_v${{ matrix.version }} ]; then | ||
mv Logs_v${{ matrix.version }}/*.log . | ||
else | ||
mkdir Logs_v${{ matrix.version }} | ||
fi | ||
env: | ||
LOG_TOKEN: ${{ secrets.LOG_TOKEN }} | ||
- uses: julia-actions/setup-julia@v1 | ||
with: | ||
version: ${{ matrix.version }} | ||
arch: ${{ matrix.arch }} | ||
- uses: julia-actions/cache@v1 | ||
- uses: julia-actions/julia-buildpkg@v1 | ||
- uses: julia-actions/julia-runtest@v1 | ||
- name: Commit logs and push back to repo # only push logs if PR is not from a fork | ||
if: ${{ ! github.event.pull_request.head.repo.fork }} | ||
run: | | ||
cd ${GITHUB_WORKSPACE}/test/Logs | ||
mv *.log Logs_v${{ matrix.version }} | ||
git add -f Logs_v${{ matrix.version }} | ||
git commit -m "Update test logs for Julia v${{ matrix.version }}" | ||
git pull --rebase testlog main # pull again to avoid conflicts from other versions | ||
git push testlog main | ||
- uses: julia-actions/julia-processcoverage@v1 | ||
- uses: codecov/codecov-action@v3 | ||
with: | ||
file: lcov.info |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to ensure we're testing on 1.9 (though I guess this is covered by
1
for "latest"?)There's some new features in 1.9 that might motivate us to stop supporting older versions in GenX v0.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
'1'
ensures we're testing on the latest stable release. We could also keep only the current stable release ('1'
), and the long-term support (LTS
) release (right now, v1.6.7) as other packages do.