Separate new build and retirement eligibility #392

cfe316 · 2023-03-28T00:15:25Z

This addresses #391 .

sambuddhac · 2023-06-23T20:29:43Z

@cfe316 , is this still draft or complete?

cfe316 · 2023-06-27T19:45:47Z

This is not yet complete or ready for review.

sambuddhac · 2023-06-27T19:49:52Z

OK !!!

gmantegna · 2023-08-24T22:23:57Z

FYI this will need to be checked for compatibility with the VRESTOR module.

cfe316 · 2023-08-25T15:47:42Z

Old format to new format

New_Build[old] to New_Build[new], Can_Retire
1 --> 1,1
0 --> 0,1
-1 --> 0,0

gmantegna · 2023-08-25T19:13:52Z

src/load_inputs/load_generators_data.jl

@@ -30,9 +30,11 @@ function load_generators_data!(setup::Dict, path::AbstractString, inputs_gen::Di
 	# Set of storage resources with symmetric charge/discharge capacity
 	inputs_gen["STOR_SYMMETRIC"] = gen_in[gen_in.STOR.==1,:R_ID]
 	# Set of storage resources with asymmetric (separte) charge/discharge capacity components
-	inputs_gen["STOR_ASYMMETRIC"] = gen_in[gen_in.STOR.==2,:R_ID]
+	STOR_ASYMMETRIC = gen_in[gen_in.STOR.==2,:R_ID]


Why do you do this for STOR_ASYMMETRIC and STOR_ALL but not STOR_SYMMETRIC? Also this is separate from the purpose of this PR, correct? That's fine if so but wanted to check.

src/load_inputs/load_generators_data.jl

gmantegna · 2023-08-25T19:19:38Z

src/load_inputs/load_generators_data.jl

+        invalid_newbuild = df.New_Build.==-1
+        if any(invalid_newbuild)
+            @info "Deprecated '-1' entries in the 'New_Build' column.


Suggest throwing an error (or at least strong warning) instead of an @info if users do have the Can_Retire column.

gmantegna · 2023-08-25T19:20:33Z

src/load_inputs/load_generators_data.jl

+which are -1 (indicating the ability to be retired).  This input format is deprecated
+and may be removed in a future version. Instead, use a column 'Can_Retire',
+with entries of either 0 or 1. New_Build should be similarly restricted to {0,1}."


Can we reference the documentation here?

gmantegna

See comments for suggestions. I have not stress tested personally but I will once the comments are addressed.

gmantegna

See comment on info statement.

gmantegna · 2023-08-25T22:26:48Z

src/load_inputs/load_generators_data.jl

+        retirable = df[df.New_Build.!=-1, :R_ID]
+        if !isempty(retirable)
+            @info "The generators input file, 'New_Build' column, has some entries


This info message is not accurate. The "retirable" set which triggers the warning refers to resources with New_Build not equal to -1, which is inconsistent with the warning message which complains about resources with New_Build equal to -1. Perhaps we can just throw a more generic warning message about not having the Can_Retire column if this column is not found? And remind users of the correct input format? (What 0/1 means in each column)

Plz lmk if this is satisfactory.

Putting my Slack comments here for record keeping purposes: I think that we should require the Can_Retire column, and throw the info message anytime it is not present. Otherwise, it will not be possible to change the default Can_Retire value to 0 (which I would assume we would want if this column is optional) without breaking backward compatibility.

cfe316 · 2023-08-31T18:45:49Z

Notes from the meeting today:
May want to wait until v0.4 in order to make some backward-incompatible changes.

Previously this was one column "New_Build" which could be 0, 1, or -1. Now, New_Build should be either 0 or 1 and Can_Retire should be either 0 or 1.

and make names more consistent

cfe316 · 2023-10-24T17:42:14Z

src/load_inputs/load_generators_data.jl

+    if deprecated_newbuild_canretire_interface(df)
+        retirable = df.New_Build .!= -1
+    else
+        retirable = df.Can_Retire .== 1
+    end
+    return Set(findall(retirable))
+end
+
+function resources_which_can_be_built(df::DataFrame)::Set{Int64}
+    buildable = df.New_Build .== 1
+    return Set(findall(buildable))
+end


These are the key functions.

cfe316 · 2023-10-24T17:43:47Z

@gmantegna This is complete now.

Backward compatible (with warning) ✔️
Documentation ✔️
Tested ✔️

I suppose for safety we might want to add a check that if you're using the new interface there should be only 1 or 0 in New_Build.
Added safety check ✔️ .

Updated Example cases ✔️ .
Updated CHANGELOG ✔️ .

gmantegna

Thanks!

Change the New_Build column to accept only {0, 1}; add a new required column Can_Retire which handles that feature separately (also {0, 1}). The change is backward-compatible, with a warning to update. --------- Co-authored-by: Gabe Mantegna <[email protected]>

cfe316 marked this pull request as draft March 28, 2023 00:15

cfe316 requested a review from sambuddhac March 29, 2023 14:02

cfe316 self-assigned this Mar 31, 2023

sambuddhac force-pushed the Develop branch from f6ed566 to 7948fd0 Compare April 27, 2023 19:25

cfe316 force-pushed the separateNew_Build_and_Retire branch from c6fdd50 to 9accef8 Compare August 1, 2023 21:07

GenXProject deleted the branch GenXProject:develop August 2, 2023 15:12

GenXProject closed this Aug 2, 2023

sambuddhac reopened this Aug 2, 2023

sambuddhac changed the base branch from Develop to develop August 2, 2023 15:29

cfe316 force-pushed the separateNew_Build_and_Retire branch from 9accef8 to 79f6f92 Compare August 25, 2023 14:39

cfe316 marked this pull request as ready for review August 25, 2023 15:45

cfe316 requested a review from gmantegna August 25, 2023 15:45

gmantegna reviewed Aug 25, 2023

View reviewed changes

src/load_inputs/load_generators_data.jl Outdated Show resolved Hide resolved

gmantegna reviewed Aug 25, 2023

View reviewed changes

gmantegna requested changes Aug 25, 2023

View reviewed changes

cfe316 force-pushed the separateNew_Build_and_Retire branch from 65824ee to eeffd3e Compare August 25, 2023 20:00

gmantegna requested changes Aug 25, 2023

View reviewed changes

lbonaldo force-pushed the develop branch from c1ac911 to c51fad9 Compare September 18, 2023 16:36

cfe316 assigned gmantegna Oct 3, 2023

cfe316 added 3 commits October 24, 2023 10:02

Separate new-buildability and ability to retire

13660c5

Previously this was one column "New_Build" which could be 0, 1, or -1. Now, New_Build should be either 0 or 1 and Can_Retire should be either 0 or 1.

Re-align with specification in docs

81ff243

improve deprecation warnings

535bbed

cfe316 and others added 9 commits October 24, 2023 10:02

Update examples

445909b

CHANGELOG message

6c30670

Undo past changes

fbdec34

Undo past changes

9b10e94

Introduce fewer new variables

01bd68a

and make names more consistent

Consistency

37ebc50

fix bug

d9cec7e

Improve info message

82af974

Update interface

190dcac

cfe316 force-pushed the separateNew_Build_and_Retire branch from 5b64023 to 190dcac Compare October 24, 2023 17:20

Format message

2b6c7fc

cfe316 commented Oct 24, 2023

View reviewed changes

cfe316 added 2 commits October 24, 2023 13:53

Update interface

9a7331e

Update message

da8318a

gmantegna approved these changes Oct 24, 2023

View reviewed changes

cfe316 added 4 commits October 24, 2023 14:34

Fix example settings: 1->1,1

13e492b

Update Input_data_explained

a0f294a

Fix MoM example

d2a78c0

Update PiecewiseFuel_CO2_Example

75da6a4

cfe316 merged commit 8d8a0ac into GenXProject:develop Oct 24, 2023
1 check passed

cfe316 deleted the separateNew_Build_and_Retire branch October 24, 2023 18:59

filippopecci mentioned this pull request Jan 6, 2024

Possible bug when using exogenous capacities in multi-stage models with separation of new build and can retire. #605

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separate new build and retirement eligibility #392

Separate new build and retirement eligibility #392

cfe316 commented Mar 28, 2023

sambuddhac commented Jun 23, 2023

cfe316 commented Jun 27, 2023 •

edited

Loading

sambuddhac commented Jun 27, 2023

gmantegna commented Aug 24, 2023

cfe316 commented Aug 25, 2023

gmantegna Aug 25, 2023

gmantegna Aug 25, 2023

gmantegna Aug 25, 2023

gmantegna left a comment

gmantegna left a comment

gmantegna Aug 25, 2023

cfe316 Aug 25, 2023

gmantegna Sep 5, 2023

cfe316 commented Aug 31, 2023

cfe316 Oct 24, 2023

cfe316 commented Oct 24, 2023 •

edited

Loading

gmantegna left a comment

Separate new build and retirement eligibility #392

Separate new build and retirement eligibility #392

Conversation

cfe316 commented Mar 28, 2023

sambuddhac commented Jun 23, 2023

cfe316 commented Jun 27, 2023 • edited Loading

sambuddhac commented Jun 27, 2023

gmantegna commented Aug 24, 2023

cfe316 commented Aug 25, 2023

Old format to new format

gmantegna Aug 25, 2023

Choose a reason for hiding this comment

gmantegna Aug 25, 2023

Choose a reason for hiding this comment

gmantegna Aug 25, 2023

Choose a reason for hiding this comment

gmantegna left a comment

Choose a reason for hiding this comment

gmantegna left a comment

Choose a reason for hiding this comment

gmantegna Aug 25, 2023

Choose a reason for hiding this comment

cfe316 Aug 25, 2023

Choose a reason for hiding this comment

gmantegna Sep 5, 2023

Choose a reason for hiding this comment

cfe316 commented Aug 31, 2023

cfe316 Oct 24, 2023

Choose a reason for hiding this comment

cfe316 commented Oct 24, 2023 • edited Loading

gmantegna left a comment

Choose a reason for hiding this comment

cfe316 commented Jun 27, 2023 •

edited

Loading

cfe316 commented Oct 24, 2023 •

edited

Loading