Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Binary parameter ‘TimeDomainReduction’ #786

Closed
WeiAi-Energy opened this issue Nov 12, 2024 · 3 comments
Closed

[Question]: Binary parameter ‘TimeDomainReduction’ #786

WeiAi-Energy opened this issue Nov 12, 2024 · 3 comments
Labels
question Further information is requested

Comments

@WeiAi-Energy
Copy link

Question

In Tutorial 1, it says that 'For example, to use TimeDomainReduction, you would set its parameter to 0', but in the table Model structure related settings parameters, it says that 'TimeDomainReduction: 0 = Use the data in the main case folder; do not perform clustering', so it seems there is a contradictory. Which one is correct?

Additional context

No response

@WeiAi-Energy WeiAi-Energy added the question Further information is requested label Nov 12, 2024
@WeiAi-Energy WeiAi-Energy changed the title [Question]: Binary variable ‘TimeDomainReduction’ [Question]: Binary parameter ‘TimeDomainReduction’ Nov 12, 2024
@abooda1981
Copy link

Hello, I am not one of the maintainers or anything but my operating assumption is that the latter is correct. Certainly, when I change TimeDomainReduction = 0 in the genxsettings file, the simulation takes relatively longer, suggesting that the clustering is not happening in this case.

@lbonaldo
Copy link
Collaborator

Hello @WeiAi-Energy, Thank you for catching this, and thanks @abooda1981 for assisting! You’re absolutely right—TimeDomainReduction: 1 enables TDR. I’ll push a fix right away.

As a general tip, whenever in doubt, I recommend checking the documentation. For example, here’s the page about the model settings. Regarding the TimeDomainReduction parameter, it states:

1 = Use time domain reduced inputs available in the folder defined by the TimeDomainReductionFolder setting. If such a folder doesn’t exist or is empty, time domain reduction will process the input data and save the results there.

I hope this clarifies things!

@lbonaldo
Copy link
Collaborator

I’m closing this issue as resolved. Please feel free to reopen it if further discussion is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants