Refactor reserves #562

cfe316 · 2023-10-12T00:44:48Z

This doesn't quite compile yet for technical reasons related to add_similar_to_expression!.

I tried refactoring some of the reserve formulations in order to better understand how they should work for fusion, and I think others might appreciate the simplifications.

cfe316 · 2023-10-13T00:50:50Z

This works now. The results for the ISONE_Trizone case (which may be the only standard test case that uses Reserves) are identical when just changing the hydro_res formulation. They unfortunately change due to numerical issues with the storage_all_reserves formulation, but I've checked that the constraints are the same. For example see commit aa6b7a6.

Overall, using add_similar_to_expression! lets us avoid the combinatorial explosion of REG/RSV/CapacityReserveMargin. The same technique should be applied to other reserves formulations.

lbonaldo

Thanks @cfe316. This PR is an excellent refactoring. I checked the logic, and it looks correct to me. I added a few comments to the code that are mostly tiny fixes.

lbonaldo · 2023-11-10T04:27:11Z

src/model/expression_manipulation.jl

Where is _sum_expression defined?

That's weird, I don't know.

lbonaldo · 2023-11-10T04:37:28Z

src/model/expression_manipulation.jl

+    new_axes = (set, time_range)
+    expr = JuMP.Containers.DenseAxisArray(aff_exprs.data, new_axes...)
+    return expr
+end


We should include a test to this functions and add it to expression_manipulation_test.jl

I've added tests now.

lbonaldo · 2023-11-10T04:46:04Z

src/model/resources/storage/storage_all.jl

@@ -160,136 +160,58 @@ function storage_all_reserves!(EP::Model, inputs::Dict, setup::Dict)



CapacityReserveMargin = setup["CapacityReserveMargin"] > 0

src/model/resources/storage/storage_all.jl

lbonaldo · 2023-11-10T04:48:22Z

src/model/resources/storage/storage_all.jl

+    eff_down(y) = dfGen[y, :Eff_Down]
+
+	# Maximum storage contribution to reserves is a specified fraction of installed capacity
+    @constraint(EP, [y in STOR_REG, t in 1:T], vREG[y, t] <= dfGen[y,:Reg_Max] * eTotalCap[y])


you could abstract also dfGen[y,:Reg_Max]

Suggested change

@constraint(EP, [y in STOR_REG, t in 1:T], vREG[y, t] <= dfGen[y,:Reg_Max] * eTotalCap[y])

reg_max(y) = dfGen[y,:Reg_Max]

@constraint(EP, [y in STOR_REG, t in 1:T], vREG[y, t] <= reg_max(y) * eTotalCap[y])

lbonaldo · 2023-11-10T04:50:46Z

src/model/resources/storage/storage_all.jl

+
+	# Maximum storage contribution to reserves is a specified fraction of installed capacity
+    @constraint(EP, [y in STOR_REG, t in 1:T], vREG[y, t] <= dfGen[y,:Reg_Max] * eTotalCap[y])
+    @constraint(EP, [y in STOR_RSV, t in 1:T], vRSV[y, t] <= dfGen[y,:Rsv_Max] * eTotalCap[y])


and dfGen[y,:Rsv_Max]

cfe316 · 2023-11-13T02:12:39Z

Here are the results of the refactor:

Costs / 1e9 for the RealSystemExample/ISONE_Trizone case, which includes THERM, HYDRO, VRE, MUST_RUN, and STOR generators.

5.865087 Reserves=0

Reserves=1
5.883106 original
5.883112 refactored

I then increased Reg_Req_Percent_Demand and Rsv_Req_Percent_Demand to 0.1 (10x and 3x increases).

6.281472 original
6.281460 refactored

These numbers are very similar; I'd say this was a success.

codecov · 2023-11-13T18:20:57Z

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (6f7ec0d) 38.37% compared to head (72cc97a) 39.22%.

❗ Current head 72cc97a differs from pull request most recent head 13be2dd. Consider uploading reports for the commit 13be2dd to get more accurate results

Files	Patch %	Lines
src/model/resources/hydro/hydro_res.jl	0.00%	21 Missing ⚠️
src/model/resources/thermal/thermal_no_commit.jl	0.00%	21 Missing ⚠️
src/model/resources/storage/storage_asymmetric.jl	0.00%	10 Missing ⚠️
src/model/resources/storage/storage_symmetric.jl	80.95%	4 Missing ⚠️
...riable_renewable/curtailable_variable_renewable.jl	95.00%	2 Missing ⚠️
src/model/resources/storage/storage_all.jl	94.44%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #562      +/-   ##
===========================================
+ Coverage    38.37%   39.22%   +0.84%     
===========================================
  Files          126      126              
  Lines         6480     6205     -275     
===========================================
- Hits          2487     2434      -53     
+ Misses        3993     3771     -222

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Move x/p <= y to x <= p * y This should be a mathematically identical formulation yet gives different numerical results.

Co-authored-by: Luca Bonaldo <[email protected]>

This fixes GenXProject#573, where Reserves + Num_VRE_Bins > 1 would lead to the VRE_NO_POWER_OUT resources being able to contribute an infinite amount to the reserves. This fixes GenXProject#574, where VRE power output constraints were being applied length(VRE) times to all VRE resources, when Reserves = 1.

lbonaldo · 2023-11-17T20:31:33Z

Here are the results of the refactor:

Costs / 1e9 for the RealSystemExample/ISONE_Trizone case, which includes THERM, HYDRO, VRE, MUST_RUN, and STOR generators.
5.865087 Reserves=0

Reserves=1
5.883106 original
5.883112 refactored
I then increased Reg_Req_Percent_Demand and Rsv_Req_Percent_Demand to 0.1 (10x and 3x increases).
6.281472 original
6.281460 refactored
These numbers are very similar; I'd say this was a success.

@cfe316 Thank you for the new commits! Could you please also share the settings of the solver you used to run the example?

cfe316 force-pushed the refactor-reserves branch from 5d2c951 to 42fb14c Compare October 12, 2023 19:22

cfe316 marked this pull request as ready for review October 13, 2023 00:44

This was referenced Oct 13, 2023

HYDRO resources cannot have different REG/RSV classes #561

Closed

STOR_ASYMMETRIC resources without REG have no limit on vCHARGE if Reserves=1 and other STOR_ASYM_REG resources exist #564

Closed

Redundant constraints in storage_symmetric #566

Closed

cfe316 requested review from gmantegna and lbonaldo October 24, 2023 01:19

cfe316 force-pushed the refactor-reserves branch from f76505b to 550c55c Compare October 26, 2023 21:01

cfe316 force-pushed the refactor-reserves branch 2 times, most recently from 0dfc526 to d48efd9 Compare November 9, 2023 20:30

lbonaldo reviewed Nov 10, 2023

View reviewed changes

cfe316 force-pushed the refactor-reserves branch 2 times, most recently from 036933a to 55a9b88 Compare November 13, 2023 01:59

cfe316 mentioned this pull request Nov 13, 2023

Duplicated power output constraints for VRE when Reserves are turned on #574

Closed

cfe316 force-pushed the refactor-reserves branch from 55a9b88 to 72cc97a Compare November 13, 2023 18:11

cfe316 added 12 commits November 14, 2023 14:15

Refector reserves

5ab8d8a

Revert changes to storage

25a0659

First set of constr

4330877

Second move

f363eaa

Thirdmove

fced3dd

Fifth move

5834b79

Fifth move

f59cec4

Move x/p <= y to x <= p * y This should be a mathematically identical formulation yet gives different numerical results.

Sixth move

11c683a

Final changes

723578e

Minor cleanup

b1ff0d4

Typo in previously-unused branch

6d5bcc7

Refactor storage_symmetric

92e1394

cfe316 and others added 19 commits November 14, 2023 14:15

Remove unneeded lines

3615524

Refactor storage_asymmetric

158d9c5

Remove extra constraint

68c617e

Refactor thermal_commit reserves

8c08712

Remove note about duplication

47dec42

refactor therm_no_commit

29b7322

Fix storage_all capres

048df4d

Fix capres access

d150f50

Make T an integer again, not UnitRange

74bb719

add expression creation function

0957306

Use new expression manipulation function

3f9c6a8

Update src/model/resources/storage/storage_all.jl

579abcd

Co-authored-by: Luca Bonaldo <[email protected]>

Fix typo

a2a7946

Update note string

07b96bc

Abstract reg_max, rsv_max

3d2946c

add tests

021c08c

Add additional test

5ee48ff

Fix test

ef16c18

cfe316 force-pushed the refactor-reserves branch from 72cc97a to 13be2dd Compare November 14, 2023 19:15

RuaridhMacd mentioned this pull request Nov 14, 2023

Extend expression_manipulations.jl to some variables #579

Merged

cfe316 mentioned this pull request Nov 15, 2023

Separate reserves into creation and constraints #580

Merged

lbonaldo approved these changes Nov 17, 2023

View reviewed changes

cfe316 merged commit 2ef54dc into GenXProject:develop Nov 18, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor reserves #562

Refactor reserves #562

cfe316 commented Oct 12, 2023

cfe316 commented Oct 13, 2023

lbonaldo left a comment

lbonaldo Nov 10, 2023

cfe316 Nov 11, 2023

lbonaldo Nov 10, 2023 •

edited

Loading

cfe316 Nov 11, 2023

lbonaldo Nov 10, 2023

lbonaldo Nov 10, 2023

lbonaldo Nov 10, 2023

cfe316 commented Nov 13, 2023 •

edited

Loading

codecov bot commented Nov 13, 2023 •

edited

Loading

lbonaldo commented Nov 17, 2023

		@@ -160,136 +160,58 @@ function storage_all_reserves!(EP::Model, inputs::Dict, setup::Dict)

	@constraint(EP, [y in STOR_REG, t in 1:T], vREG[y, t] <= dfGen[y,:Reg_Max] * eTotalCap[y])
	reg_max(y) = dfGen[y,:Reg_Max]
	@constraint(EP, [y in STOR_REG, t in 1:T], vREG[y, t] <= reg_max(y) * eTotalCap[y])

Refactor reserves #562

Refactor reserves #562

Conversation

cfe316 commented Oct 12, 2023

cfe316 commented Oct 13, 2023

lbonaldo left a comment

Choose a reason for hiding this comment

lbonaldo Nov 10, 2023

Choose a reason for hiding this comment

cfe316 Nov 11, 2023

Choose a reason for hiding this comment

lbonaldo Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

cfe316 Nov 11, 2023

Choose a reason for hiding this comment

lbonaldo Nov 10, 2023

Choose a reason for hiding this comment

lbonaldo Nov 10, 2023

Choose a reason for hiding this comment

lbonaldo Nov 10, 2023

Choose a reason for hiding this comment

cfe316 commented Nov 13, 2023 • edited Loading

codecov bot commented Nov 13, 2023 • edited Loading

Codecov Report

lbonaldo commented Nov 17, 2023

lbonaldo Nov 10, 2023 •

edited

Loading

cfe316 commented Nov 13, 2023 •

edited

Loading

codecov bot commented Nov 13, 2023 •

edited

Loading