STOR_ASYMMETRIC resources without REG have no limit on vCHARGE if Reserves=1 and other STOR_ASYM_REG resources exist

[cfe316]

There's a logical error in the construction of STOR_ASYMMETRIC resources which don't have REG.

• storage_asymmetric_reserves! sets the upper limit on vCHARGE for these kinds of resources. It should be less than eTotalCapCharge.

The construction of the sets:

STOR_ASYMMETRIC = inputs["STOR_ASYMMETRIC"]

STOR_ASYM_REG = intersect(STOR_ASYMMETRIC, inputs["REG"]) # Set of asymmetric storage resources with REG reserves
STOR_ASYM_NO_REG = setdiff(STOR_ASYMMETRIC, STOR_ASYM_REG) # Set of asymmetric storage resources without REG reserves

The existing logic:

if !isempty(STOR_ASYM_REG)
    @constraints(STOR_ASYM_REG)
else
    @constraints(STOR_ASYM_NO_REG)
end

However, there can be some resources in each of these two sets. The correct logic should be (as in other similar functions)

if !isempty(STOR_ASYM_REG)
    @constraints(STOR_ASYM_REG)
end
if !isempty(STOR_ASYM_NO_REG)
    @constraints(STOR_ASYM_NO_REG)
end

[cfe316]

This would be fixed by #562 .

[cfe316]

The fix for this has been merged to develop.