Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups for power-loss, whitespace #13

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

thinkyhead
Copy link
Contributor

@thinkyhead thinkyhead commented Nov 19, 2018

  • Remove all trailing whitespace.
  • Replace tab indentations with spaces.
  • Add standard power-loss test G-codes.
  • Wrap some pins-dependent code in conditionals.
  • Organize power-loss detected / resume / set-mix code into functions.

To see only the non-whitespace changes: Concise Diff.

@thinkyhead thinkyhead force-pushed the clean_trailing_whitespace branch 3 times, most recently from f23b5ba to e71c3ee Compare November 19, 2018 06:05
@thinkyhead thinkyhead force-pushed the clean_trailing_whitespace branch from e71c3ee to 1264ff4 Compare November 19, 2018 07:08
@thinkyhead thinkyhead force-pushed the clean_trailing_whitespace branch from 1264ff4 to fac8209 Compare December 11, 2018 16:27
@thinkyhead thinkyhead changed the title Remove all trailing whitespace Fixups for power-loss, whitespace Dec 11, 2018
@thinkyhead thinkyhead force-pushed the clean_trailing_whitespace branch from fac8209 to eaee9b1 Compare December 20, 2018 21:22
@thinkyhead
Copy link
Contributor Author

In testing I still see one issue with this (on A10M and A20M). The power-loss recovery file ("BIN") is not deleted (or zeroed) at the end of the print job. I will post the solution if I find it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant