Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Integrate Google Sheet as an alternative input source #70

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

waryankaa
Copy link
Collaborator

We added the files we will use to implement integrating a google form and google sheets

What is the current behavior?

What is the new behavior if this PR is merged?

Two new Files were added

Type of change

Please describe the pull request as one of the following:

  • Bug fix
  • Breaking change
  • New feature
  • Documentation update
  • Other

Other information

This PR has:

  • Commit messages that are correctly formatted
  • Tests for newly introduced code
  • Docstrings for newly introduced code

Developers

@

Abigail Waryanka, Kai'lani Woodard Peter Snipes, Zack Devers

Copy link
Collaborator

@corlettim corlettim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you update your branch with master

@enpuyou
Copy link
Contributor

enpuyou commented Mar 31, 2021

The PR probably shouldn't be merged, if all it contributes are two empty files. However, the team can still work on this branch and use this PR to fix #32.

@enpuyou
Copy link
Contributor

enpuyou commented Apr 2, 2021

Hi @waryankaa, when you have time, could you change the title of the PR from Issue#32 to something more descriptive that will sum up the change/purpose? Thank you!

@enpuyou enpuyou added enhancement New feature or request high priority labels Apr 7, 2021
@enpuyou enpuyou changed the title Issue#32 WIP: Integrate Google Sheet as an alternative input source Apr 10, 2021
@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #70 (0d2ebaf) into master (3e6b8a6) will decrease coverage by 1.02%.
The diff coverage is n/a.

❗ Current head 0d2ebaf differs from pull request most recent head 9cfd168. Consider uploading reports for the commit 9cfd168 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   92.09%   91.07%   -1.03%     
==========================================
  Files           6        6              
  Lines         253      224      -29     
==========================================
- Hits          233      204      -29     
  Misses         20       20              
Impacted Files Coverage Δ
src/markdown.py 88.05% <0.00%> (-1.95%) ⬇️
src/analyzer.py 93.24% <0.00%> (-1.08%) ⬇️
src/constants.py 100.00% <0.00%> (ø)

@noorbuchi
Copy link
Collaborator

@zaethovenn @Peter-Snipes @kailaniwoodard @waryankaa can you please provide a status update on this PR. Is it still WIP or is it ready for review? Thanks for your work!

@zaethovenn
Copy link
Collaborator

zaethovenn commented Apr 11, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants