-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description for GatorMiner features #69
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mai1902, thanks for working on this issue. There are still some issues that need to be addressed. In general, can I ask your team to rename the folder doc
into docs
, and also rename the markdown file names to perhaps a quasi-snakecase format (e.g. DocumentSimilarity.md
to document-similarity.md
). For the descriptions, I think it should first include some high-level summarization of what the page does, while also providing instructions or explanations of the visualizations (what are being compared, what are the options to select from, etc.). In addition, do your team plan to also document the subpages (e.g. frequencies by students)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thanks for your work on this documentation. I added few change requests for now but I will be doing a more comprehensive review later. Please let me know if you have any questions in the meantime.
I forgot to add this in my review. Can you please make sure to remove unneeded files like |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 6 6
Lines 253 253
=======================================
Hits 233 233
Misses 20 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thanks for your continued work on documenting the functionality of GatorMiner. Here are few suggestions that you can get started on. I will be reviewing this PR more closely in the next few days so please let me know if you have any questions. In addition to the requested changes mentioned here, please make sure to delete the .Rhistory
files that this PR is adding. Lastly, I noticed a small issue when I ran streamlit on this branch, here are some screenshots and explanations:
In this example in the frequency analysis page, I think it would make more sense to add the expandable container immediately after the header instead of after the charts, This can be done by changing where you're creating the expandable text container.
What is the current behavior?
In every display page of GatorMiner features, there's no description to the function of each features.
What is the new behavior if this PR is merged?
In every display page of GatorMiner features, there's a description button that if user click it, it will return the text explaining the function of each GatorMiner features.
Type of change
Please describe the pull request as one of the following:
Other information
There are four concerns/improvements that my team want to address before merging this pull request:
This PR has:
Developers
@Mai1902 @TheShiny1 @Kevin487 @Batmunkh0419