Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.3.0 #415

Merged
merged 15 commits into from
Nov 5, 2024
Merged

Release 2.3.0 #415

merged 15 commits into from
Nov 5, 2024

Conversation

ianroberts
Copy link
Member

…adios

If a checkbox or radio option specifies "htmlLabel" then this will be rendered _as HTML_ instead of the regular "label" being rendered as text.  Use cases for this could be

- showing the labels in differnt colours `<span style='color:red'>Negative</span>`
- adding emphasis to particular parts of the label `<b>Reasonably</b> confident`
- adding margin to the bottom of an option to separate groups of related choices `<div style='margin-bottom: 1.5em'>Last option in this group</div>`
In newer docker versions, compose is a plugin to the docker command rather than a command in its own right.
Use inline-flex for the checkbox/radio `<label>` so that even if the label includes something like a div with bottom margin, the helptext popup still appears beside the label rather than underneath it
Added special classes to the CSS that users can add to a span or something inside an option's htmlLabel to affect the margin above or below the option as a whole (as opposed to just above or below the label).
HTML labels for radio/checkbox options
build: updated various dependencies
Documentation and changlog for release 2.3.0
@ianroberts ianroberts requested a review from twinkarma November 4, 2024 17:23
Copy link

github-actions bot commented Nov 4, 2024

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 83.83 83.17 64 83.83
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 83.83 83.17 64 83.83
_jrpc 94.11 91.66 83.33 94.11
_ index.js 94.11 91.66 83.33 94.11 29-30,38-40
_utils 82 82.1 57.89 82
_ annotations.js 97.75 70.83 100 97.75 35-36
_ dict.js 88.88 83.33 100 88.88 3-4
_ expressions.js 80.08 82.35 80 80.08 ...,188-190,201-218
_ index.js 73.6 100 14.28 73.6 ...4-65,76-82,93-94

@greenwoodma greenwoodma self-requested a review November 5, 2024 14:06
Copy link

@greenwoodma greenwoodma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (I'd actually looked at these changes earlier, so happy to approve)

@ianroberts ianroberts merged commit 5e7b5c4 into master Nov 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants